From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 1/6] Add initial type alignment support
Date: Tue, 24 Apr 2018 20:23:00 -0000 [thread overview]
Message-ID: <877eow8ibd.fsf@tromey.com> (raw)
In-Reply-To: <c46973d1-ab2f-2c50-4272-a6a3bb277b85@redhat.com> (Pedro Alves's message of "Tue, 24 Apr 2018 20:16:53 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> + if (gdbarch_ptr_bit (gdbarch) == 32 &&
>> + TYPE_CODE (type) == TYPE_CODE_INT && TYPE_LENGTH (type) > 4)
>> + return 4;
Pedro> && on the other line.
Hah. Actually I think I meant to refactor this all a bit and make an
outer if that checked gdbarch_ptr_bit.
Tom
next prev parent reply other threads:[~2018-04-24 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 15:22 [RFA 0/6] Teach gdb about type alignment Tom Tromey
2018-04-24 15:22 ` [RFA 4/6] Expose type alignment on gdb.Type Tom Tromey
2018-04-24 16:59 ` Eli Zaretskii
2018-04-24 15:22 ` [RFA 5/6] Remove rust_type_alignment Tom Tromey
2018-04-24 15:22 ` [RFA 3/6] Reindent type_object_getset in py-type.c Tom Tromey
2018-04-24 15:22 ` [RFA 2/6] Handle alignof and _Alignof Tom Tromey
2018-04-24 17:04 ` Eli Zaretskii
2018-04-24 19:17 ` Pedro Alves
2018-04-24 20:23 ` Tom Tromey
2018-04-27 18:02 ` Pedro Alves
2018-04-27 20:53 ` Tom Tromey
2018-04-30 16:46 ` Tom Tromey
2018-04-26 20:45 ` Tom Tromey
2018-04-27 18:05 ` Pedro Alves
2018-04-26 20:54 ` Tom Tromey
2018-04-24 15:22 ` [RFA 1/6] Add initial type alignment support Tom Tromey
2018-04-24 19:16 ` Pedro Alves
2018-04-24 20:23 ` Tom Tromey [this message]
2018-04-24 15:22 ` [RFA 6/6] Remove long_long_align_bit gdbarch attribute Tom Tromey
2018-04-24 15:24 ` Tom Tromey
2018-04-24 17:17 ` Anton Kolesov
2018-04-26 20:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eow8ibd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).