From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62444 invoked by alias); 26 Apr 2017 00:17:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62435 invoked by uid 89); 26 Apr 2017 00:17:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 26 Apr 2017 00:17:18 +0000 Received: (qmail 28616 invoked by uid 0); 26 Apr 2017 00:17:19 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy7.mail.unifiedlayer.com with SMTP; 26 Apr 2017 00:17:19 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id CoHG1v0092f2jeq01oHK3j; Tue, 25 Apr 2017 18:17:19 -0600 X-Authority-Analysis: v=2.2 cv=Ibz3YSia c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=f9GBSlbUhtSXXvzFousA:9 Received: from 75-166-63-71.hlrn.qwest.net ([75.166.63.71]:46190 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1d3Adv-0008A8-Vn; Tue, 25 Apr 2017 18:17:16 -0600 From: Tom Tromey To: Sergio Durigan Junior Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter References: <20170423160446.17062-1-tom@tromey.com> <87zif4s5po.fsf@redhat.com> Date: Wed, 26 Apr 2017 00:17:00 -0000 In-Reply-To: <87zif4s5po.fsf@redhat.com> (Sergio Durigan Junior's message of "Tue, 25 Apr 2017 14:27:31 -0400") Message-ID: <877f283tv9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1d3Adv-0008A8-Vn X-Source-Sender: 75-166-63-71.hlrn.qwest.net (bapiya) [75.166.63.71]:46190 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00699.txt.bz2 >> + /* Set this flag if a "More frames" message is to be printed. */ >> + PRINT_MORE_FRAMES = 16, >> }; Sergio> Not that I want you to fix this, but I like when bitflags are set using Sergio> the "1 << X" notation. Oh, well... I added a patch for this and I also changed this code to use DEF_ENUM_FLAGS_TYPE, which seems better. I'll send this change separately. >> + assert ((flags & PRINT_MORE_FRAMES) != 0); Sergio> gdb_assert here, right? Oops, yes. I made this change. Tom