* [PATCH][SPARC] Add missing include in test program gdb.arch/sparc-sysstep.c
@ 2015-11-19 16:13 Jose E. Marchesi
2015-11-19 16:20 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Jose E. Marchesi @ 2015-11-19 16:13 UTC (permalink / raw)
To: gdb-patches
Ok to commit?
commit fbe1572b5ad640e67fa1dec4ef9d3f95feb8079c
Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Date: Thu Nov 19 11:22:31 2015 -0500
sparc: fix build of gdb/testsuite/gdb.arch/sparc-sysstep.c
This patch adds a missing include that makes the test program to not be
built (--Wimplicit-function-declaration).
gdb/testsuite/ChangeLog:
2015-11-19 Jose E. Marchesi <jose.marchesi@oracle.com>
* gdb.arch/sparc-sysstep.c: Include unistd.h for getpid.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e712bc5..d7dee9b 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,9 @@
2015-11-19 Jose E. Marchesi <jose.marchesi@oracle.com>
+ * gdb.arch/sparc-sysstep.c: Include unistd.h for getpid.
+
+2015-11-19 Jose E. Marchesi <jose.marchesi@oracle.com>
+
* gdb.base/callfuncs.exp (fetch_all_registers): Filter out the
pstate register when comparing registers values in
sparc64-*-linux-gnu targets to avoid spurious differences.
diff --git a/gdb/testsuite/gdb.arch/sparc-sysstep.c b/gdb/testsuite/gdb.arch/sparc-sysstep.c
index 79e344b..a29174f 100644
--- a/gdb/testsuite/gdb.arch/sparc-sysstep.c
+++ b/gdb/testsuite/gdb.arch/sparc-sysstep.c
@@ -1,3 +1,4 @@
+
/* Test single-stepping system call instructions in sparc.
Copyright 2014-2015 Free Software Foundation, Inc.
@@ -18,6 +19,7 @@
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <signal.h>
+#include <unistd.h>
int global;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][SPARC] Add missing include in test program gdb.arch/sparc-sysstep.c
2015-11-19 16:13 [PATCH][SPARC] Add missing include in test program gdb.arch/sparc-sysstep.c Jose E. Marchesi
@ 2015-11-19 16:20 ` Pedro Alves
2015-11-20 9:43 ` Jose E. Marchesi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2015-11-19 16:20 UTC (permalink / raw)
To: Jose E. Marchesi, gdb-patches
On 11/19/2015 04:20 PM, Jose E. Marchesi wrote:
> diff --git a/gdb/testsuite/gdb.arch/sparc-sysstep.c b/gdb/testsuite/gdb.arch/sparc-sysstep.c
> index 79e344b..a29174f 100644
> --- a/gdb/testsuite/gdb.arch/sparc-sysstep.c
> +++ b/gdb/testsuite/gdb.arch/sparc-sysstep.c
> @@ -1,3 +1,4 @@
> +
> /* Test single-stepping system call instructions in sparc.
Spurious change above? Otherwise OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][SPARC] Add missing include in test program gdb.arch/sparc-sysstep.c
2015-11-19 16:20 ` Pedro Alves
@ 2015-11-20 9:43 ` Jose E. Marchesi
0 siblings, 0 replies; 3+ messages in thread
From: Jose E. Marchesi @ 2015-11-20 9:43 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
> diff --git a/gdb/testsuite/gdb.arch/sparc-sysstep.c b/gdb/testsuite/gdb.arch/sparc-sysstep.c
> index 79e344b..a29174f 100644
> --- a/gdb/testsuite/gdb.arch/sparc-sysstep.c
> +++ b/gdb/testsuite/gdb.arch/sparc-sysstep.c
> @@ -1,3 +1,4 @@
> +
> /* Test single-stepping system call instructions in sparc.
Spurious change above? Otherwise OK.
Pushed, modulus the chunk above.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-20 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 16:13 [PATCH][SPARC] Add missing include in test program gdb.arch/sparc-sysstep.c Jose E. Marchesi
2015-11-19 16:20 ` Pedro Alves
2015-11-20 9:43 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).