From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Gabriel Krisman Bertazi <gabriel@krisman.be>, gdb-patches@sourceware.org
Subject: Re: [PING] [PATCH] Fix gdb.fortran/array-element.exp failures.
Date: Wed, 10 Sep 2014 16:11:00 -0000 [thread overview]
Message-ID: <877g1blakv.fsf@redhat.com> (raw)
In-Reply-To: <20140910125037.GN28404@adacore.com> (Joel Brobecker's message of "Wed, 10 Sep 2014 05:50:37 -0700")
On Wednesday, September 10 2014, Joel Brobecker wrote:
> My only comment is that simplications are indeed good, but it is
> better if you can submit those separately from other changes.
> It's easier to review the patch series that way, and it also
> allows us separate the real change from the enhancement which
> is expected to be a no-op.
Mea culpa.
I thought it would be nice to simplify the testcase in one shot, because
it seemed to me that the error happened *also* because the testcase was
not very clear. And since I had applied the patch, investigated and
figured out that it did the right thing, I thought it'd be good to
simplify it too.
Sorry if it made the review harder!
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-09-10 16:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 5:58 Gabriel Krisman Bertazi
2014-07-04 15:35 ` Sergio Durigan Junior
2014-07-04 23:20 ` Gabriel Krisman Bertazi
2014-07-05 12:14 ` Sergio Durigan Junior
2014-07-05 17:17 ` Gabriel Krisman Bertazi
2014-07-06 19:03 ` Sergio Durigan Junior
2014-07-14 23:28 ` Gabriel Krisman Bertazi
2014-08-17 4:07 ` Gabriel Krisman Bertazi
2014-08-26 0:30 ` [PING] " Gabriel Krisman Bertazi
2014-09-04 19:31 ` Gabriel Krisman Bertazi
2014-09-09 13:09 ` Joel Brobecker
2014-09-09 14:55 ` Gabriel Krisman Bertazi
2014-09-09 15:45 ` Joel Brobecker
2014-09-09 18:17 ` Gabriel Krisman Bertazi
2014-09-10 12:50 ` Joel Brobecker
2014-09-10 16:11 ` Sergio Durigan Junior [this message]
2014-09-11 3:25 ` Gabriel Krisman Bertazi
2014-09-09 15:08 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g1blakv.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gabriel@krisman.be \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).