From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26212 invoked by alias); 13 Jan 2014 20:31:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26198 invoked by uid 89); 13 Jan 2014 20:31:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2014 20:31:16 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0DKVElu004533 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Jan 2014 15:31:15 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0DKVCL9022189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 13 Jan 2014 15:31:13 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] main_name cleanups References: <1389028297-16977-1-git-send-email-tromey@redhat.com> <52CAFDCD.7070000@redhat.com> Date: Mon, 13 Jan 2014 20:31:00 -0000 In-Reply-To: <52CAFDCD.7070000@redhat.com> (Pedro Alves's message of "Mon, 06 Jan 2014 19:02:37 +0000") Message-ID: <877ga31v5b.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00377.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I was just wondering why duplicate the main name/language both in the Pedro> progspace and in the objfiles? Wouldn't just storing a pointer to the Pedro> objfile that has the main name and its language in the progspace Pedro> be enough? If not, then it'd be good to mention that in a comment, Pedro> I think. The current series is just a simple transform of the existing code. I think your proposed approach would work ok, though the current code returns "main" even if it isn't defined in the program -- so we'd need some extra hack for that. I'll add a note about this. If we ever want to support DW_AT_main_subprogram, we'll need some other changes as well, since multiple functions can be marked that way. Tom