From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C2CF43858D38 for ; Mon, 22 Apr 2024 08:50:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2CF43858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2CF43858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713775846; cv=none; b=O5eUrPCvlqEGc4YX+APLtducGLyiKrmvLBWQyj6beaokZYDkyczsa6+m/DPBewX/Crktmhht7tdnPOImxFIUfpuPu/vL3kEefj/X9Xg/zkeXLlNjCypkbUJdonV/jPg4Qq+vi9gWFUo6JcS2fSHAK8r6mWRObX2U8zOYuOUgzKM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713775846; c=relaxed/simple; bh=vHL5ChMgUz30rkwlGOk2zUMQPx3mwfxTdwv1r/EoBZQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=EV+zpqNwRc2/v4YYcZkc5NJeLb8qvgrZ34wljCn2aVEVB51EiyaKvrQd5ENIxeL8R748nMDmQTePKcON6exV/mYDPyVB3tjLJ3jbTuvPnXTKd69sJrqbs0SRdd+1NoijWU2BwVEGDnPoydPBth+BLKz0Yz1ARtbKkKnMWVinOvw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713775844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ulC3vXbc0E8tJP3v4Y+RT6SYKeuVORb7xccbkTLKrCE=; b=atsU02GH98MZ+qwYvzWG6XrNgy7RvdfKw9UkinnLgmw3ioSlUMIh0mlAncdMS7PWZUWIYa r1kqupYUEulZlj/BthE22kX2OsP4S6yCbxemCMGsIcIo0a3K4Z6krpEEbLgiyln5y8EUrg ID2GRkeNeZ9VEhfry9iPeBONKNDb2tc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-lfx8DmnENKy3uxDEBydHfg-1; Mon, 22 Apr 2024 04:50:42 -0400 X-MC-Unique: lfx8DmnENKy3uxDEBydHfg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-34a4ded7d49so3458091f8f.1 for ; Mon, 22 Apr 2024 01:50:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713775841; x=1714380641; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TiWTaXTes+tK6GH37nzRZ5b81g7woOi+lU1BLYmchZY=; b=wzOT+G+AheOXHKUybj4/dKdBEAfZKuee2/QJa5ZN/jBQg9RT+iO5GtX7DDMMNPpC1E DGNCR1lXNzVy3FHQJeaZ6uUIVbFwl6i+t0yRaWq5WpVdJHAZBvDnHylZwTFYZX7//lI0 7dbBcGoKtP+p+Tx9zfJWMkohWbYAZN6DuUSwyCTyqyVjztjqhhjd5EDGD2+P1LVDMVtq fp6cAHS7Xc8kWAPUB3yPUGEF5m1WhMbSgJ3rprFsPuK0RG0U2Do3kTOJI+qfI23wdNVd KmFAi1jA9vuHIaAylfSAhHb2QCjapQMCXpZFw9AxcqQu/i2BH24a31QiWLyIyUmocahA oRwQ== X-Forwarded-Encrypted: i=1; AJvYcCW48/FM8JXChGoimeRGCF5oPFjQHYQge8nVZq0XTMliSjKVwynRR2YLDcrgY6W96JMh+UMaOMPuBCv4to06WW/IWfq3eHwy3yx6HQ== X-Gm-Message-State: AOJu0Yz6YDQ68BxyXx3x+J58AvHx/OtopW1x/LVpKcIEztFSM1k2hH5T geoAsafJv7H6b3s6Oa+Ptu8qLq293OgLrACLVgcj9KG6RgFb1C7pt2k0l2WtRM2qAhgKMyleiev 5tjPBckOQwNt5x5ZHkPK1xptU8gH+xGJBXD66n/Nc2mdd5vZMjYhJv5Ur3P8= X-Received: by 2002:a05:6000:150:b0:34a:688a:4bde with SMTP id r16-20020a056000015000b0034a688a4bdemr5128160wrx.42.1713775841463; Mon, 22 Apr 2024 01:50:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0AtryEmXkZlMDwBphMq0Cm1fslMP3kIVjUOoJ0hbBxcE7OYu0aVCF8EbhUM5/mf1J+W6XEA== X-Received: by 2002:a05:6000:150:b0:34a:688a:4bde with SMTP id r16-20020a056000015000b0034a688a4bdemr5128138wrx.42.1713775840860; Mon, 22 Apr 2024 01:50:40 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id ay13-20020a05600c1e0d00b0041a7581f8b6sm1392273wmb.23.2024.04.22.01.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 01:50:40 -0700 (PDT) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Cc: Jim Blandy , Mike Wrighton , Nathan Sidwell , Hafiz Abid Qadeer Subject: Re: [PATCH 03/12] Document "E.MESSAGE" RSP errors In-Reply-To: <20240419151342.1592474-4-pedro@palves.net> References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-4-pedro@palves.net> Date: Mon, 22 Apr 2024 09:50:40 +0100 Message-ID: <878r15hjbz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > For many years, GDB has accepted a "E.MESSAGE" error reponse, in > addition to "E NN". For many packets, GDB strips the "E." before > giving the error message to the user. For others, GDB does not strip > the "E.", but still understands that it is an error, as it starts with > "E", and either prints the whole string, or ignores it and just > mentions an error occured (same as for "E NN"). > > This has been the case for as long as I remember. Now that I check, I > see that it's been there since 2006 (commit a76d924dffcb, also here: > https://sourceware.org/pipermail/gdb-patches/2006-September/047286.html). > All along, I actually thought it was documented. Turns out it wasn't. > > This commit documents it, in the new "Standard Replies" section, near > where we document "E NN". > > The original version of this 3-patch documentation series was a single > CodeSourcery patch that documented the textual error as > "E.NAME.MESSAGE", with MESSAGE being 8-bit binary encoded. But I > think the ship has sailed for that. GDBserver has been sending error > messages with more than one "." for a long while, and with no binary > encoding. Still, I've preserved the "Co-Authored-By" list of the > original larger patch. > > Change-Id: Ie4fee3d00d82ede39e439bf162e8cb7485532fd8 > Co-Authored-By: Jim Blandy > Co-Authored-By: Mike Wrighton > Co-Authored-By: Nathan Sidwell > Co-Authored-By: Hafiz Abid Qadeer > --- > gdb/doc/gdb.texinfo | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 57260a5b2fa..d6184d52841 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -42557,6 +42557,10 @@ number. In almost all cases, the protocol does = not specify the > meaning of the error numbers; @value{GDBN} usually ignores the > numbers, or displays them to the user without further interpretation. > =20 > +@item @samp{E.@var{message}} > +An error has occurred; @var{message} is the textual error message, > +encoded in @sc{ascii}. I think we should document here that the 'qRcmd' and 'm' packets don't accept this reply format. Alexandra H=C3=A1jkov=C3=A1 has a patch series which has not been posted ye= t which will extend these packets in a backward compatible way so that E.message can be used, but until that arrives we should probably document this limitation. Thanks, Andrew