From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E3A66385C6E8 for ; Sun, 31 Mar 2024 10:27:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3A66385C6E8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E3A66385C6E8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711880845; cv=none; b=Cdbm5TM/3NOy/X0ul383Id/RYfleOJyNBWCl9yvKfnWwuvV9wdevM8vh9X9Zl2tnIOl0/fwaWiA3qePKRwDUxHWKJGPEBvns5vGAoF3lRpZ1DC1aGBLxufSXKGpVkHUk8lUBn/iCKcCH18k0UXAve74N/U1mEZv97IlnH43SQq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711880845; c=relaxed/simple; bh=X6t2LYghX+VkIpdJPq1F0Qr7m/lhUT6vWlFbJ13fiLk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xQ2u7qOyqy/Df94mVARlSyqeE0zJ2ZlvdZzgFunteYj09i+50RbQ4CP/UZO/9+IK+rq9k7dRpKHYnryiqo2Aqmo70hwsb2qQyD4rCy7vsUazUh7zzMdX/+8bG7o2apXaETxoYq+zp8uVuO4h8YB55je9WeeFwmVf3LIBsOT9OQE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711880843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0wxQ0bEc8lRvlqZzDNiWMUH4ySuhwYN39rqjYjRwoB8=; b=fI6XfwvltqA8UVQ733cb4s7nXuUUr5WLFC2Bc7b2ds2EgdXPhiwsWWpCS6M8S+lE22gyIl zOqCbAYyEE9B6ktRMBk0hGlop3nY28f0a7yloXuQkdpKea/40B4BZ0hPr4fAEE/H/H4cK+ EuuBTkgnf8GCFPWVmKRIkTIL7pnnFmY= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-dgXHRz9VNsylQ_SaIQPgGA-1; Sun, 31 Mar 2024 06:27:21 -0400 X-MC-Unique: dgXHRz9VNsylQ_SaIQPgGA-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-56dbeb46016so915990a12.0 for ; Sun, 31 Mar 2024 03:27:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711880839; x=1712485639; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0wxQ0bEc8lRvlqZzDNiWMUH4ySuhwYN39rqjYjRwoB8=; b=TufJvh3QCd/+LA+ws5DVa5eeukSYRNqzH/jDA0L/5dVVvhZRFaXunfYqL3ckyNfZDu lcpOK17o6Z0gsH+pnkIWcYmvazW1N1+meLBbHphWT1XWvRqYQktALIYoXaaQZ6NwvPWI 3y5sAnag12He7Yx7idPTvLN04/k6W3lwhLq9GwBYPalARBsqPoScYRqSQErZ8KCJ3DoI IAYC8gYBA9hn40FT/NFc1saJA9HX3C1Y+Vv9v1GZUKFHUylywGT46A4wzwXrJvXQ23YF Qgj6bGgMsy08Icbc/VWynv6A9jlKkbKF1TAwmLyo44buqRJezj9jYG9eABVJZ+WQ4QgQ kWVg== X-Gm-Message-State: AOJu0Ywx0br2TxH41xTQ6bf9Nxx04mldd76bfn1nQMDLjU0HTTrTkRe5 CWL/6D6blsBQJLnR3woUKU7Kc4NtMhWeFGkvafYneD/A+dWsf+tuuoqH+aMiwLVhXDAzXKkw1wA 9jn/s8CTAP2c5u+8eL3aybs+zZXbkIUcpY8YKCiDUUlvkEevdsVKZLymDTP3SUUQ25vJKA8QaDp BPd7TNebzm60QpjJPlVwU3il35dYru6DSZJn7DUe1/ghw= X-Received: by 2002:a50:c050:0:b0:568:aad2:f835 with SMTP id u16-20020a50c050000000b00568aad2f835mr4521003edd.20.1711880839411; Sun, 31 Mar 2024 03:27:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAzHVet+R6DXvoDrRnH5GxiriolMGJzZm9MxD6HMr5K6v1N3QpehNroHz73RXgRSBjsfDAXA== X-Received: by 2002:a50:c050:0:b0:568:aad2:f835 with SMTP id u16-20020a50c050000000b00568aad2f835mr4520990edd.20.1711880838866; Sun, 31 Mar 2024 03:27:18 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id o19-20020aa7c7d3000000b0056dd3626035sm29229eds.91.2024.03.31.03.27.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Mar 2024 03:27:18 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv9 04/14] gdb: the extra_string in a dprintf breakpoint is never nullptr In-Reply-To: <4f415e1a1abea8d9b4e9e8c8837dd7e17097a005.1709651994.git.aburgess@redhat.com> References: <4f415e1a1abea8d9b4e9e8c8837dd7e17097a005.1709651994.git.aburgess@redhat.com> Date: Sun, 31 Mar 2024 11:27:18 +0100 Message-ID: <878r1y4ry1.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: > Given the changes in the previous couple of commits, this commit > cleans up some of the asserts and 'if' checks related to the > extra_string within a dprintf breakpoint. > > This commit: > > 1. Adds some asserts to update_dprintf_command_list about the > breakpoint type, and that the extra_string is not nullptr, > > 2. Given that we know extra_string is not nullptr (this is enforced > when the breakpoint is created), we can simplify > code_breakpoint::code_breakpoint -- it no longer needs to check for > the extra_string is nullptr case, > > 3. In dprintf_breakpoint::re_set we can remove the assert (this will > be checked within update_dprintf_command_list, we can also remove > the redundant 'if' check. > > There should be no user visible changes after this commit. I've gone ahead and committed this patch. Thanks, Andrew