From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Aaron Merey <amerey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev
Date: Thu, 14 Mar 2024 06:31:28 -0600 [thread overview]
Message-ID: <878r2lm1un.fsf@tromey.com> (raw)
In-Reply-To: <bcebafe9-670f-4489-aea7-60c34cfbc21f@simark.ca> (Simon Marchi's message of "Wed, 13 Mar 2024 21:39:07 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> However, I'd like if we could analyze the problem a bit further to
Simon> understand more precisely what happens, just to be sure that there isn't
Simon> a more fundamental problem and we're not just papering over the problem.
The issue is corrupt DWARF -- the DIE specifies an abbrev that doesn't exist.
Whether erroring here is the best result is harder to say. For example,
would it make more sense to terminate the scanning but still install any
symbols seen before this point?
I tend to agree that this approach is ok, though. If the file is
corrupt it seems fine to lose a few symbols, or maybe even the whole
thing.
Tom
next prev parent reply other threads:[~2024-03-14 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 20:18 Aaron Merey
2024-03-14 1:39 ` Simon Marchi
2024-03-14 12:31 ` Tom Tromey [this message]
2024-03-14 13:56 ` Simon Marchi
2024-03-14 14:31 ` Tom Tromey
2024-03-14 17:45 ` Aaron Merey
2024-03-14 17:52 ` Simon Marchi
2024-03-14 12:29 ` Tom Tromey
2024-03-14 12:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r2lm1un.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).