From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id A2B1B385841E for ; Thu, 14 Mar 2024 12:31:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2B1B385841E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2B1B385841E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419493; cv=none; b=EmFwUl9A1/jWk4QPFlnaegeB5OT5NxTnxgmbgV6ceNH//mw/moVD2tF7oUVWCyO/g68OqO079EdzI3M64a4MQ64AAlDHAPRQwNcXrXKf5kei1q4SvbcVXKC3RBT9Xg8kwKcLqN27uhv2t/KEmim6y3G7PBkZTUhsfeQFmFEjrgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710419493; c=relaxed/simple; bh=UIvqqlsbL4qKjHqErCcIRuK/oaG8QwLn8tBwPFvK/Co=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MBcqwjBUAZngDLHfF8MDgepExuBe/Bb+ms1ZUxsgnQ5ZM/J/gPePnQT947M+tbA5NkNj0ySg+WEl04hL/DYmocp4MwadwyyYSrDBwFs1eWu9LOG2eRiAKwhaKJwTZVlM+huGhnmVoBZ2L2/0Gv3x5clNv2yc0mGcKYZrDEwW4O4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id kk56rNbTZHXmAkkF8reJa1; Thu, 14 Mar 2024 12:31:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id kkF8rOCoW6Fn6kkF8rczZj; Thu, 14 Mar 2024 12:31:30 +0000 X-Authority-Analysis: v=2.4 cv=cpqdkU4i c=1 sm=1 tr=0 ts=65f2ee22 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=dzWzf_mpAAAA:8 a=4PncExpBG1tukajF8iIA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K36y4CjA1IFv5rKkQX8WI6Yk2LgGpFQXMojapLYzKoo=; b=Biz0ukWGSt3NjqtmknSzV7XQ1w G9HNVVtXhHT1/5IrGA+aOEHJklchQ5Ep6H706WdBWCnZc652ElH+EqwdBmL8xFINnXAK2LKTe0Ix0 +hYYrHYEXXGSZfaY2zw4AOQoo; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:46722 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rkkF7-002StV-2K; Thu, 14 Mar 2024 06:31:29 -0600 From: Tom Tromey To: Simon Marchi Cc: Aaron Merey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev References: <20240313201827.1853989-1-amerey@redhat.com> X-Attribution: Tom Date: Thu, 14 Mar 2024 06:31:28 -0600 In-Reply-To: (Simon Marchi's message of "Wed, 13 Mar 2024 21:39:07 -0400") Message-ID: <878r2lm1un.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rkkF7-002StV-2K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:46722 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOtWj2ubbNN32qqjgT4lhdrLwskeIy0/1fbGjO4Jr+bb7j0xLFcn4yYvadjwbkc+GTL8Vz6VT/CpbtDgO8Gs3cyRWEq8ylClW5YdYH2j2FuibdU0wNjT yTwWurFNvvefmma/vmvub3hg5/fQ472rLxwgRFl5FJZsR2oKkGggdlwFmKGVhIug4b+BklpzG0iSGkhNMBBtSo38tcEh9z8bkUs= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> However, I'd like if we could analyze the problem a bit further to Simon> understand more precisely what happens, just to be sure that there isn't Simon> a more fundamental problem and we're not just papering over the problem. The issue is corrupt DWARF -- the DIE specifies an abbrev that doesn't exist. Whether erroring here is the best result is harder to say. For example, would it make more sense to terminate the scanning but still install any symbols seen before this point? I tend to agree that this approach is ok, though. If the file is corrupt it seems fine to lose a few symbols, or maybe even the whole thing. Tom