From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/linux-nat.c: Add "Accessing inferior memory" section
Date: Fri, 23 Feb 2024 09:16:01 -0700 [thread overview]
Message-ID: <878r3byx4u.fsf@tromey.com> (raw)
In-Reply-To: <20240221202840.772802-1-pedro@palves.net> (Pedro Alves's message of "Wed, 21 Feb 2024 20:28:40 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> This commit adds a new "Accessing inferior memory" comment section to
Pedro> gdb/linux-nat.c that explains why we prefer /proc/pid/mem over
Pedro> alternatives.
Pedro> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30453
Aside from the typo pointed out by Mikhail, this looks good.
Thank you for writing this, this kind of commentary is very valuable.
Tom
next prev parent reply other threads:[~2024-02-23 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 20:28 Pedro Alves
2024-02-21 20:55 ` Terekhov, Mikhail
2024-02-23 17:01 ` Pedro Alves
2024-02-23 16:16 ` Tom Tromey [this message]
2024-02-23 17:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r3byx4u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).