From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 7A1973858C60 for ; Thu, 8 Feb 2024 18:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A1973858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A1973858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707417936; cv=none; b=pM1syLMUGnKUuxs7nRCkWUZZ5aaKR+hBu4nSY7DBRB27HINWT8cnNzvZcBQjy6kmlNpxwZefSfLQfigcLZa2joiP2FXnwP/fixm6elRxuACyLem6s+QpW1VkwqG8+MyuRG1Edbbopcx0G7SXYzD1g1402uFnB2i/OeZGEFLwUfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707417936; c=relaxed/simple; bh=0RLik9RuvfYsrQYOVkVBzBCcYgdynt6rylQBZzMgWOo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iog2LoYlfc+DJMm00aYgN4NgGyYHfrQiImvM5Ck4d8JLmqqYVWPuKfUwCMdNWJP65U3nBaGdruOG8adFfRbKvbuTzH53j3UH+Il0UltwFw1R6DIqJYdB3k5J+seLt4blqS0ecT7Ql8P7txCONWRmi0CVw1Ga+8I5oxqYd/ZBX9c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id Y430rHO5m9gG6Y9OwrtgqK; Thu, 08 Feb 2024 18:45:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Y9OvrWjI24GXcY9OvrxPVP; Thu, 08 Feb 2024 18:45:33 +0000 X-Authority-Analysis: v=2.4 cv=FO64xPos c=1 sm=1 tr=0 ts=65c5214d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=7qMSWDmNJnckence:21 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=ulm7Ar_PeT91775HJZYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rl7siFogmRQJa5CUuxHUSZnglNhIUjx7cwIultMExCc=; b=FfXRMQgUhHSjSIFczQrGgChgv+ K7eVpwG52oBouSYgM2VkMwwp7UtQ0ZVEL3GAqU1NG/Gb3xCWns/YGoQXeQbeKVGkLOqSVJd3C7Lk7 s4LzhzE/3r6hOBWKtHw7WEmjB; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:34860 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rY9Ou-0037nF-31; Thu, 08 Feb 2024 11:45:32 -0700 From: Tom Tromey To: Natalia Saiapova Cc: gdb-patches@sourceware.org, tankut.baris.aktemur@intel.com Subject: Re: [PATCH 3/6] gdb, cli: pass the argument of a set command to its callback. References: <20231229104202.7878-1-natalia.saiapova@intel.com> <20231229104202.7878-4-natalia.saiapova@intel.com> X-Attribution: Tom Date: Thu, 08 Feb 2024 11:45:31 -0700 In-Reply-To: <20231229104202.7878-4-natalia.saiapova@intel.com> (Natalia Saiapova's message of "Fri, 29 Dec 2023 10:41:59 +0000") Message-ID: <878r3uaj78.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rY9Ou-0037nF-31 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:34860 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJkFCFtb9eRZ0lVl0fQoc9cQSnCEN+QEDZ5q96DuCue3lFSqOf9E11thMPtH1aYobCRrTq4gej7mhBBAuZ8F25AbzPXJ9PTzOimr23IrvEm+STybVhlH FGs0wG84sB/OnfoFObm+BF2P1CBuTTTkNPLjcB/IFACz8yZ3vwi+NEX6nQv1SzEW2Efx4mn9RWmAYbKlpgCkDpF7PwfJTP0xMuY= X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Natalia" == Natalia Saiapova writes: Natalia> This might be useful, if some commands need to have a special case if Natalia> run w/o arguments. Do you have an example of this? I wonder if this is really something we want to allow. Natalia> diff --git a/gdb/infrun.c b/gdb/infrun.c Natalia> index e10bde94744..b8feef6bc2d 100644 Natalia> --- a/gdb/infrun.c Natalia> +++ b/gdb/infrun.c Natalia> @@ -2385,9 +2385,6 @@ ptid_t Natalia> user_visible_resume_ptid (int step) Natalia> { Natalia> ptid_t resume_ptid; Natalia> - thread_info *tp = nullptr; Natalia> - if (inferior_ptid != null_ptid) Natalia> - tp = inferior_thread (); This seems to be an unrelated change. Tom