From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4B22938582A5 for ; Wed, 6 Dec 2023 16:22:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B22938582A5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B22938582A5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701879739; cv=none; b=lJAeLtUxy5zzHu84/8czgNm+UwwTUDKEm3TQB3eNIeFk0O0nIalNT6uM7L5THw8PKa7jQLxdboXSWG4ISWiHCRyMv+nDKLHoknepXygoTIwr1e/syE5dkWbsVFWItmixqbR7yDQFYS9vwsAU5jrPtRrZbkA9rEerYIrzlsf+4GM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701879739; c=relaxed/simple; bh=2w3+QJqp6WPQsahcGsom9FSReOrn1PpUXaEQOwGMCYA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GyaRahm5Q9aK8v4pg3qEdjnjhO6d9+kmGC5uzWXUBMyHxfkLj7KE080jBOBbK+n1PgJBVE6hsrIa/vwxywzuvnNtaWZTDuoRzBKt+oQ7G7Kgb5aStd23tSgQMtngw6bh8c6klyIs/dPPzTYODqnEtn7mGUNVtm+BXV8gojtl5hE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701879737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QBzB5lKoiqytrD7RXHZS5rXrQIF0SqyLiY5PwMzI4f4=; b=Okgc0n2JMzTLUjADE5/fLRdreFguLlE+9kwSWb6qU/l0UUBoQjrb34xJ1WWnnHAnnMnnpj G+hktEro4YI0FgWUUfB5Xe7TaYXE0B0YAQ0FAvV6W9Fs2jWQrykol1pD9kcfDr0u6z4LLx XM4m9lHxzqaEVEpYWzL/q2JRxX99+cI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-XWsjn0hROFiyRmZYTOetJw-1; Wed, 06 Dec 2023 11:22:14 -0500 X-MC-Unique: XWsjn0hROFiyRmZYTOetJw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3335231c733so548625f8f.0 for ; Wed, 06 Dec 2023 08:22:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701879733; x=1702484533; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QBzB5lKoiqytrD7RXHZS5rXrQIF0SqyLiY5PwMzI4f4=; b=lwycg7LjGmUR71PwdoYtHrBXJyoePgoJIs9y7fRr14xT3FXiTc/CUa/5HaEiHBYxn2 N7rNzkvf9g+Ajh9Xfu1u6l+kxI5/d63YvZ4fOFVLK827qsaTmmfBYExSEWdt1o6OLn+I VUiYjuZj0bWmRuTnCVcxtRlyq39mraRaE+yH5eV8dW93gnhB2GBOCV4aBcM1If5mwe/h 1gQi1NU1iMoS2UyxAnGP/DBte1BwuNPbxv/I7L1Nu9d4k7/rirVMVO47PD0eLrOU+Nl3 Mqdvl2rPi7AeBlilS1qDq0dZJvDveQ3O3xGSySnw1kOf0E5EN2z6KnWdH8z3S7YyTd65 hMxA== X-Gm-Message-State: AOJu0Yy/mEBFiIXSh6grGMKFxc3JVKOe9QeWwGAPzcWfJQwvCol353b8 ODxp4eE/fiQqUlQfNLK6h/f5Ju/chZjmDuCd3G4aCOjQFYBvqPtXYhWIYWNXg1OjUDTiAxGbXyk PDl4qoMgQjO0DjH4XGEMm5A== X-Received: by 2002:a5d:664f:0:b0:333:46a5:6d1c with SMTP id f15-20020a5d664f000000b0033346a56d1cmr638022wrw.15.1701879733642; Wed, 06 Dec 2023 08:22:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IG7V1i2fx71C6MQ/NEb6u6v5FSz5+VeKAptxR+pglY/bavPXfEHOYhGX/RloDcILBwVwsIsQQ== X-Received: by 2002:a5d:664f:0:b0:333:46a5:6d1c with SMTP id f15-20020a5d664f000000b0033346a56d1cmr638015wrw.15.1701879733311; Wed, 06 Dec 2023 08:22:13 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id a5-20020a5d53c5000000b003333c2c313bsm48721wrw.100.2023.12.06.08.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 08:22:13 -0800 (PST) From: Andrew Burgess To: Keith Seitz , Guinevere Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: make gdb_get_worker_threads reads default number of threads In-Reply-To: <481d8b16-8e3f-45aa-9c01-ed398bb63dd5@redhat.com> References: <20231205152609.741237-1-blarsen@redhat.com> <481d8b16-8e3f-45aa-9c01-ed398bb63dd5@redhat.com> Date: Wed, 06 Dec 2023 16:22:12 +0000 Message-ID: <878r67gv2j.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Keith Seitz writes: > Hi, > > On 12/5/23 07:26, Guinevere Larsen wrote: > >> One such example is the current buildbot instance (at least the clang >> version). This commit adds a new clause to the gdb_get_worker_threads >> that detects the default worker thread message. >> --- >> gdb/testsuite/lib/gdb.exp | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index d0990dcfe0e..148476cf42d 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -10034,6 +10034,9 @@ proc gdb_get_worker_threads { {testname ""} } { >> -wrap -re "^The number of worker threads GDB can use is unlimited \\(currently ($::decimal)\\)\\." { >> set worker_threads $expect_out(1,string) >> } >> + -wrap -re "^The number of worker threads GDB can use is the default \\(currently ($::decimal)\\)\\." { >> + set worker_threads $expect_out(1,string) >> + } >> -wrap -re "^The number of worker threads GDB can use is ($::decimal)\\." { >> set worker_threads $expect_out(1,string) >> } > > This is new: > > 33ae45434d0ab1f7de365b9140ad4e4ffc34b8a2 > Date: Mon Dec 4 14:23:17 2023 +0000 > > gdb: Enable early init of thread pool size > > That commit changes the "is unlimited" text from > maintenance_show_worker_threads to "is the default": > > gdb_printf (file, _("The number of worker threads GDB " > - "can use is unlimited (currently %zu).\n"), > + "can use is the default (currently %zu).\n"), > gdb::thread_pool::g_thread_pool->thread_count ()); > > So this patch can be further simplified. Otherwise LGTM. Indeed. This was my mistake for not retesting after the final rebase. As Keith said s/unlimited/the default/ instead of adding a whole new regexp, and this is good to go. Approved-By: Andrew Burgess Thanks, Andrew