From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 000C43858D37 for ; Thu, 30 Nov 2023 19:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 000C43858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 000C43858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372231; cv=none; b=Jn46l5Xv5UeaP5IuX671iMALtfkDINDtz6eL7b5PCgKWB9ILS7pQdmt5YAr8R+vIQgpdg9Q6JTe9R/w/p8RIIIbFXfAgi0xBd4TKHjOQ9SVQLdO3aTGa4HqqKQS/tp8R8u1dK8KyYWt3yKX+xj/NwifNnXXpOuHRajINix184bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701372231; c=relaxed/simple; bh=faEp0BwxpiEu46FmjcnHQl5P/ALwz0uAHZJzye0oneY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=s3jb6UbZJiX5UskDSlm+Ing7lmwtyjrfWq7/TLUtsbgCK2STLG5C/i5yeprpm4W1GdO9ds1nIkkkKwuzNIeFWbNDruQ0D919LKwp3fOYiIeELtpG8c4iM/rsh1ogIZ6w7Hn9rSLX5dT264GgFV+XChZhiJueAqnRJ3KWfLySSG0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id 8mJlrgSq3WcCI8mdZr5TX0; Thu, 30 Nov 2023 19:23:49 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 8mdYrCeAQ0xkr8mdZrckhJ; Thu, 30 Nov 2023 19:23:49 +0000 X-Authority-Analysis: v=2.4 cv=N7U6qkxB c=1 sm=1 tr=0 ts=6568e145 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=ot7tToEqtyftdFsgCcUA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1cqFLYgwXYYH6J2LA5AlaYUdhHry+1LOUY4GOycvpNQ=; b=cT+cajK/E8n1vtWgQeYIvGq+zm VSlREoif7RMXGfEuKKqkBmIrWrvCvaCs3b0ZD2Ycp6emPUPQd54O3dF7lLfCAY6k5yuADFoso9Y6E gLSGKltGP0X8l6N5UUopsoWdZ; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:54176 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r8mdY-003tJW-1e; Thu, 30 Nov 2023 12:23:48 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb/testsuite: tighten up some end-of-line patterns References: <90f05fc11d1bf8fc39af46ac057a48e1327174e2.1701280438.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 30 Nov 2023 12:23:47 -0700 In-Reply-To: <90f05fc11d1bf8fc39af46ac057a48e1327174e2.1701280438.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 29 Nov 2023 17:55:44 +0000") Message-ID: <878r6fcaf0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r8mdY-003tJW-1e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:54176 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJEYWMe7XElRBkDZtA+kIOQiw61CH1tD4I3NtMA3KNVCkl65ebhKXCHB1bo5B4tq5jKQECxrizn2F/SrDP5TOuHKUPrhRykef/cYa77xyue9BJ5lLCiX j7+f73PilC2Ilimw4tDHKKodEhd6N0Af1jnF+ezjyEhyyTQGSuw0B6EjeQhG/O8LJzCJgM7ihH3LJXt0zCrCSyV9zjBhK9JhhFU= X-Spam-Status: No, score=-3017.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> Following on from the previous commit, I searched the testsuite for Andrew> places where we did: Andrew> set eol "" Andrew> in most cases the could be replaced with "\r\n" though Andrew> in the stabs test I've switched to using the multi_line proc as that Andrew> seemed like a better choice. Andrew> In gdb.ada/info_types.exp I did need to add an extra use of $eol as Andrew> the previous pattern would match multiple newlines, and in this one Andrew> place we were actually expecting to match multiple newlines. The Andrew> tighter pattern only matches a single newline, so we now need to be Andrew> explicit when multiple newlines are expected -- I think this is a good Andrew> thing. Andrew> All the tests are still passing for me after these changes. Looks good to me, thank you. Approved-By: Tom Tromey Tom