From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id A4DE23858D28 for ; Tue, 14 Nov 2023 14:45:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4DE23858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A4DE23858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699973118; cv=none; b=PExlyROZalOtMD320rBeEnfmZNskUg6BS+LB+wWOdDYUOHH3ayt1v7+GmTNLqQ2JHdRNIvwV7QpngZmLUDhgiUxjvRdl4MNQjl3Qd3hB8ja/9pYxjh3qcwTz/c5NtIE9Ffuv2lOsa6mZ70Qghu3TC3nix+W2smtNy0KqULlIvx8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699973118; c=relaxed/simple; bh=dGk+fexOJIW0JVXvLYhxjuk2XrT5ZyBplxKjKtNiGVk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aYKAk45irKvQAA98Eur0wTE07Bb4cH9O3rp0QMaRwDVC1McGnvVWKX5zkrkxZzsc0swrGpUIQUW+4b50fkC6Q0cMLzfba1+9uiDaRV26aV4ClxuAPvOH6IdSLRjCEEhXaJENJfGFRMmEttoqIMHU7COenFntif9rMIDUL/h5C44= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id 2rcLrajLNKOkL2ufDrXx4F; Tue, 14 Nov 2023 14:45:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 2ufCrMaXLAKSc2ufCrYJqf; Tue, 14 Nov 2023 14:45:15 +0000 X-Authority-Analysis: v=2.4 cv=N6w6qkxB c=1 sm=1 tr=0 ts=655387fb a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=QyXUC8HyAAAA:8 a=kuWEnZau_jVk20dDpgYA:9 a=zZCYzV9kfG8A:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MDm+zyBK+izvaZRnhk5OByLVTaQ5ytkMVl+y5687kHc=; b=FUm+xd5arkDigMY/XDd7/8wKdO jzTKTm0GVS8bhX4jwPI+090+qeTAmOaLbeA9XHXSOLj72PgrVJf0cLIVC/wujTfPfwgdKAjKNlNgh G1zwy+xwyTwdA64Wf2+N9DDYi; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:54320 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r2ufC-001BlV-0m; Tue, 14 Nov 2023 07:45:14 -0700 From: Tom Tromey To: Mohamed Bouhaouel Cc: gdb-patches@sourceware.org, blarsen@redhat.com, eliz@gnu.org Subject: Re: [PATCH v3 3/3] gdb, zpoint: check for target hardware breakpoint support References: <20231114133532.3877-1-mohamed.bouhaouel@intel.com> <20231114133532.3877-4-mohamed.bouhaouel@intel.com> X-Attribution: Tom Date: Tue, 14 Nov 2023 07:45:13 -0700 In-Reply-To: <20231114133532.3877-4-mohamed.bouhaouel@intel.com> (Mohamed Bouhaouel's message of "Tue, 14 Nov 2023 14:35:32 +0100") Message-ID: <878r70qtqe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r2ufC-001BlV-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:54320 X-Source-Auth: tom+tromey.com X-Email-Count: 17 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGyJS7Qto8ElNzjRDwaojLfwy5c8GEqcegVqrLDF6XORifZBu6f7xCtGIDMOjVrae5aBW03Pk4G9mFihhN8zVbQkbd5S40JRFEdhja6P16E/8odKo88x IclfewqM4qtUXBGLanXA7ydTyvXJFxx79PtCiS73xu8H/0oPlllokEWO4+lLyDG8YtR/ejkDJQvXfosvTozJNvr15WMDfYawlyY= X-Spam-Status: No, score=-3018.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Mohamed Bouhaouel writes: > In 'can_use_hw_breakpoint', check if the target supports > hardware-assisted breakpoints. This will prevent GDB > from trying to insert the hardware breakpoint in case > it is not supported. Thanks. One question I have is how this is tested. Another oddity is that supposedly a remote can reply '' to a z packet, meaning it isn't supported. However, insert_hw_breakpoint (at least) doesn't seem to record this response. > + /* If hw read watchpoints are not supported while hw access are, > + GDB will try to insert the watchpoint as hw access. */ > + bool access_support = supports_z_point_type ( > + bptype_to_target_hw_bp_type (bp_access_watchpoint)); Formatting looks wrong here. Tom