From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 07B04385841C for ; Mon, 18 Sep 2023 14:49:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07B04385841C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-34fcd361e91so6812215ab.3 for ; Mon, 18 Sep 2023 07:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695048553; x=1695653353; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jLnz56fzuQxde8U6/ASnlwtFVlE2cJX2ZkrUVRiq6is=; b=Yvq5FZB1VQm+fOwcxZZb/9p/RQRh1oI5hMUPJsXVGGW1CJyIo9B6TAeTS93ewJEpdF 82/PnoVgEvr/Z/EUtM50rmolomwN5A2xK8XOS/NrXrILk+0IILc7lFqIIajByhv0/l/1 0Bva7iokhpnOCJBascVyMVmK5N8HmOGAbIRZnPfLPLfocd8eB1pvtSc8EPAixG44kP5l TMuXaCgYU1W+VsBgI8MjDJsYhcD8FcWjZ6J7W1wWEG8a3Q8tahO7ZyuXFaUmKmmZKEOD gRu1YkU4uR4PCIUDuczvsleajrVyUN6G7RtVs1ukhdhYneuWAxRDqGiYB5zerKpwmlCz +Lhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695048553; x=1695653353; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jLnz56fzuQxde8U6/ASnlwtFVlE2cJX2ZkrUVRiq6is=; b=amqPyrXYxJye0VpAE9kD9/zIpNYolOxgNqOGVq19oqPqrZqOgKLTKG/RPOyHCN+bkh syrQI3Itmj3wm/xuVSSgwA0TZK39hShwCymGwh71Dznl9PfiWFg9feoB9hoyRqGHuJHy ik/0Hx7nb3Rdqh7Y9B3thIn0FDh4+SGLezsctiL7NFXP6ZQkonT0HPeVOZjulBGC5uq3 QsshwBW6jOS0byh+k3GYhqnhbxpbu387ImTTkRTJbcIX0JBsLkEXj4zq/vOHVuTQLQ5t j/V9fLzoRJE+DwJqnZ2kd0RWtKGFPk31hLAg1Os47eC3NRwqktho1JwJMKw84Luvr/GD GP2A== X-Gm-Message-State: AOJu0YxLTLsyPzgIBw1S2tTaVjQ9+kzTHi5Lhmhm7cHpqYHXieowO3/d 26atmprD3gdPRQ13LE2PW7Olqw== X-Google-Smtp-Source: AGHT+IEVcYjReGhqzme3poU4N1wC2A+txPQ7hZirgQ6jRprrlIajwh1MMz1DFj3ihETr5CAAfFFQOQ== X-Received: by 2002:a92:cf4d:0:b0:349:3503:253b with SMTP id c13-20020a92cf4d000000b003493503253bmr10233122ilr.17.1695048553020; Mon, 18 Sep 2023 07:49:13 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id o20-20020a056638125400b0042b451aa95esm2789728jas.150.2023.09.18.07.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:49:12 -0700 (PDT) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 6/7] Convert solib-rocm to new type-safe gdb_bfd_openr_iovec References: <20230824-gdb-bfd-vec-v1-0-850e4e907ed1@adacore.com> <20230824-gdb-bfd-vec-v1-6-850e4e907ed1@adacore.com> <20230918094109.ke2zzdlvghdmehaj@octopus> X-Attribution: Tom Date: Mon, 18 Sep 2023 08:49:11 -0600 In-Reply-To: <20230918094109.ke2zzdlvghdmehaj@octopus> (Lancelot SIX's message of "Mon, 18 Sep 2023 10:41:09 +0100") Message-ID: <878r93a654.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Lancelot" == Lancelot SIX writes: Lancelot> Hi Tom, Lancelot> I have tested this patch. As it is, it fails to compile. Thank you. Lancelot> Here is a diff fixing the build. Changes are minor: Lancelot> - Change rocm_code_object_*::read to accept the " bfd *" first param Lancelot> to properly override gdb_bfd_iovec_base::read. Lancelot> - The "open" lambda passed to gdb_bfd_openr_iovec does not need to Lancelot> capture anything. I've applied it for v2. Tom