From: Andrew Burgess <aburgess@redhat.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 17/21] gdb: pass current_ui down to interp_set
Date: Tue, 12 Sep 2023 11:54:56 +0100 [thread overview]
Message-ID: <878r9bk6f3.fsf@redhat.com> (raw)
In-Reply-To: <20230908190227.96319-18-simon.marchi@efficios.com>
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> In preparation for making interp_set a method of struct ui. No behavior
> changes expected.
>
> Change-Id: I507c7701438967502d714ecda99401d785806cab
> ---
> gdb/interps.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/gdb/interps.c b/gdb/interps.c
> index 0575128b8124..18758f1f7af6 100644
> --- a/gdb/interps.c
> +++ b/gdb/interps.c
> @@ -92,24 +92,24 @@ find_interp_factory (const char *name)
> are caused by CLI commands. */
>
> static void
> -interp_set (struct interp *interp, bool top_level)
> +interp_set (ui *ui, struct interp *interp, bool top_level)
> {
Given where you're going, I'm fine with this. If we planned to stop
here then I'd say, lets use interp->m_ui instead of passing in a
separate ui parameter, but I see why this helps.
Thanks,
Andrew
> - struct interp *old_interp = current_ui->current_interpreter;
> + struct interp *old_interp = ui->current_interpreter;
>
> /* If we already have an interpreter, then trying to
> set top level interpreter is kinda pointless. */
> - gdb_assert (!top_level || !current_ui->current_interpreter);
> - gdb_assert (!top_level || !current_ui->top_level_interpreter);
> + gdb_assert (!top_level || !ui->current_interpreter);
> + gdb_assert (!top_level || !ui->top_level_interpreter);
>
> if (old_interp != NULL)
> {
> - current_ui->m_current_uiout->flush ();
> + ui->m_current_uiout->flush ();
> old_interp->suspend ();
> }
>
> - current_ui->current_interpreter = interp;
> + ui->current_interpreter = interp;
> if (top_level)
> - current_ui->top_level_interpreter = interp;
> + ui->top_level_interpreter = interp;
>
> if (interpreter_p != interp->name ())
> interpreter_p = interp->name ();
> @@ -127,7 +127,7 @@ interp_set (struct interp *interp, bool top_level)
> }
>
> /* Do this only after the interpreter is initialized. */
> - current_ui->m_current_uiout = interp->interp_ui_out ();
> + ui->m_current_uiout = interp->interp_ui_out ();
>
> /* Clear out any installed interpreter hooks/event handlers. */
> clear_interpreter_hooks ();
> @@ -151,7 +151,7 @@ set_top_level_interpreter (const char *name)
> if (interp == NULL)
> error (_("Interpreter `%s' unrecognized"), name);
> /* Install it. */
> - interp_set (interp, true);
> + interp_set (current_ui, interp, true);
> }
>
> void
> @@ -267,10 +267,10 @@ interpreter_exec_cmd (const char *args, int from_tty)
> if (interp_to_use == NULL)
> error (_("Could not find interpreter \"%s\"."), prules[0]);
>
> - interp_set (interp_to_use, false);
> + interp_set (current_ui, interp_to_use, false);
> SCOPE_EXIT
> {
> - interp_set (old_interp, false);
> + interp_set (current_ui, old_interp, false);
> };
>
> for (i = 1; i < nrules; i++)
> --
> 2.42.0
next prev parent reply other threads:[~2023-09-12 10:55 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 18:22 [PATCH 00/21] ui / interp cleansup Simon Marchi
2023-09-08 18:22 ` [PATCH 01/21] gdb: use intrusive_list for struct ui linked list Simon Marchi
2023-09-08 18:22 ` [PATCH 02/21] gdb: make interp_lookup_existing a method of struct ui Simon Marchi
2023-09-08 18:22 ` [PATCH 03/21] gdb: make interp_add " Simon Marchi
2023-09-08 18:22 ` [PATCH 04/21] gdb: make interp_lookup " Simon Marchi
2023-09-12 9:15 ` Andrew Burgess
2023-09-12 14:38 ` Simon Marchi
2023-09-08 18:22 ` [PATCH 05/21] gdb: remove ui:::add_interp and ui::lookup_existing_interp Simon Marchi
2023-09-08 18:23 ` [PATCH 06/21] gdb: uncover some current_ui uses in interp_set Simon Marchi
2023-09-08 18:23 ` [PATCH 07/21] gdb: add backlink to ui in interp Simon Marchi
2023-09-08 18:23 ` [PATCH 08/21] gdb: pass ui down to gdb_setup_readline and gdb_disable_readline Simon Marchi
2023-09-08 18:23 ` [PATCH 09/21] gdb/python: use m_ui instead of current_ui in dap_interp::init Simon Marchi
2023-09-08 18:23 ` [PATCH 10/21] gdb/mi: use m_ui instead of current_ui in mi_interp::init Simon Marchi
2023-09-08 18:23 ` [PATCH 11/21] gdb/cli: use m_ui instead of current_ui in cli_interp::resume Simon Marchi
2023-09-12 10:40 ` Andrew Burgess
2023-09-12 15:42 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 12/21] gdb/tui: use m_ui instead of current_ui in tui_interp::resume Simon Marchi
2023-09-12 10:41 ` Andrew Burgess
2023-09-08 18:23 ` [PATCH 13/21] gdb/mi: use m_ui instead of current_ui in mi_interp::resume Simon Marchi
2023-09-12 10:44 ` Andrew Burgess
2023-09-12 16:36 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 14/21] gdb/cli: use m_ui instead of current_ui in cli_interp::suspend Simon Marchi
2023-09-08 18:23 ` [PATCH 15/21] gdb/tui: use m_ui instead of current_ui in tui_interp::suspend Simon Marchi
2023-09-08 18:23 ` [PATCH 16/21] gdb/mi: use m_ui instead of current_ui in mi_interp::suspend Simon Marchi
2023-09-08 18:23 ` [PATCH 17/21] gdb: pass current_ui down to interp_set Simon Marchi
2023-09-12 10:54 ` Andrew Burgess [this message]
2023-09-12 17:17 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 18/21] gdb: make interp_set a method of struct ui Simon Marchi
2023-09-12 10:58 ` Andrew Burgess
2023-09-12 17:23 ` Simon Marchi
2023-09-12 13:41 ` Tom Tromey
2023-09-12 17:32 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 19/21] gdb: pass down current_ui to set_top_level_interpreter Simon Marchi
2023-09-11 15:15 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 20/21] gdb: make set_top_level_interpreter a method of struct ui Simon Marchi
2023-09-12 11:20 ` Andrew Burgess
2023-09-12 17:41 ` Simon Marchi
2023-09-08 18:23 ` [PATCH 21/21] gdb: make top_level_interpreter " Simon Marchi
2023-09-12 11:35 ` Andrew Burgess
2023-09-12 17:54 ` Simon Marchi
2023-09-12 11:38 ` [PATCH 00/21] ui / interp cleansup Andrew Burgess
2023-09-12 17:51 ` Simon Marchi
2023-09-12 18:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r9bk6f3.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).