From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 541173858D20 for ; Tue, 29 Aug 2023 18:01:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 541173858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-794d98181f0so76990339f.2 for ; Tue, 29 Aug 2023 11:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693332118; x=1693936918; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FqLB5Htq9TLfk7HXQymv9kYGD6soapXXhrZ8PD9JJis=; b=WFK3nMu8TvV2DWfq3UQpRUkupYOfdPTuVqBsOxeFrK2TPO9EA0I120tczB9WHzUEfR 7fMy1XF9hNgAKiVacNWistakX+LJdN+D4I8Sr2Taems1r4T7BeC/IFmI1bTnQuxHEsCu Tu0YJ3SSp1b2pwxZ9CGClvI/ZB7O535TaogB1fe0nCkh0TZVL9EiJZcBbhcZVQi2QZgr 5VJvsnbTeh0zk9pdn3jKwScFwM7m6s+HlLRDmqr0HCkw7CXNcDQidRLsHUAr7gga0Eby RWp0ypFcA3NEPtroJYpiCJu9slUx0Iv7ggFQcv+07RkANCbI5Xnq7+QOjWbvLzdXw0nf AZQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693332118; x=1693936918; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FqLB5Htq9TLfk7HXQymv9kYGD6soapXXhrZ8PD9JJis=; b=PMBaEL6AvtQLxXV+JlecF9s7kr4TKXO8Ix6Q49t1wP05bn6WOR7mot5J2aKbHgEUJ4 AZsVcy5QPHB+f7BD5iQjObFEbM47vc8mFH7QiES1OMu31JxRWiDOKRAusL6j/GZ5wqoQ i2MtK/ItcF3hkxoFj/7S2lRTZIPdeUmJJ96IY20xaHTO8zASrO2eqQ4GI4/IN+YDgcYo 1Ys2+aPsNaJLsdUWAzWHXlJAEEGPBWtzAe2CB+pivGgtklAqvIaUo5SlgvWWP5YJYn9y FUKr9veAhIMZijYy5XRVHbvEN11cDF8GIhjMcnrUfxCuMysPjZ9TxxZIJJ+powPec3M1 euuQ== X-Gm-Message-State: AOJu0YyLd5gN1q05E36btea+6nWug5gyIZpmCRU1F0L360V5G2hNamHs rNNK3GMaRPSneueWks4i1IMP5Q== X-Google-Smtp-Source: AGHT+IFdbrPRKDq4q/yZZdV+Jyd02cHMbeoNbklU/T9lxL6lQFm3B4ueSz7hsjcHUBRL7FFYtOcsyw== X-Received: by 2002:a5e:c603:0:b0:791:acd7:233f with SMTP id f3-20020a5ec603000000b00791acd7233fmr20700iok.15.1693332118628; Tue, 29 Aug 2023 11:01:58 -0700 (PDT) Received: from murgatroyd (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id ee16-20020a056638293000b0042b227eb1ddsm3198897jab.55.2023.08.29.11.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 11:01:58 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/7] Remove "highbound" parameter from value_array References: <20230829-cleanup-array-op-v2-0-3035458b0443@adacore.com> <20230829-cleanup-array-op-v2-6-3035458b0443@adacore.com> <0999f314-3565-4475-acba-6da367fc9673@polymtl.ca> X-Attribution: Tom Date: Tue, 29 Aug 2023 12:01:57 -0600 In-Reply-To: <0999f314-3565-4475-acba-6da367fc9673@polymtl.ca> (Simon Marchi's message of "Tue, 29 Aug 2023 13:53:05 -0400") Message-ID: <878r9tsp62.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> - for (idx = 1; idx < nelem; idx++) >> + for (idx = 1; idx < elemvec.size (); idx++) >> { >> if (type_length_units (elemvec[idx]->enclosing_type ()) >> != typelength) Simon> I don't know if you want to make that change, but that loop can become Simon> a range for loop. I did this in v3. Tom