From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta035.useast.a.cloudfilter.net (omta035.useast.a.cloudfilter.net [44.202.169.34]) by sourceware.org (Postfix) with ESMTPS id 5D5F83858D28 for ; Mon, 28 Aug 2023 16:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D5F83858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTP id aedzqbTJzDKaKafUgqpHjW; Mon, 28 Aug 2023 16:53:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id afUfqia8JlcNfafUgqansg; Mon, 28 Aug 2023 16:53:38 +0000 X-Authority-Analysis: v=2.4 cv=UIjOoQTy c=1 sm=1 tr=0 ts=64ecd112 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=AdUiDOcMBlUwcY4gOWwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Nn1mEUoIyATCnauaqbHtcDRmrp0qWCox2bNsX7u1WN4=; b=xIhsck3hwwmchZjN/5NY+GrIdu M4hAMsSjeb7U9voktRby+Z825efI1a8D1d/0TyfgFXWsh+KBC1XqAe/7jm8+9BqMBpJ4wzq1LO5vI D94HM1E04EKVb3PvspHY1hcaN; Received: from 75-166-150-212.hlrn.qwest.net ([75.166.150.212]:45686 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qafUf-0048Dr-1p; Mon, 28 Aug 2023 10:53:37 -0600 From: Tom Tromey To: Keith Seitz via Gdb-patches Cc: Tom Tromey , Keith Seitz Subject: Re: [PATCH] Verify COFF symbol stringtab offset References: <20230822152335.231921-1-keiths@redhat.com> <877cpnw04v.fsf@tromey.com> <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com> X-Attribution: Tom Date: Mon, 28 Aug 2023 10:53:36 -0600 In-Reply-To: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com> (Keith Seitz via Gdb-patches's message of "Fri, 25 Aug 2023 12:46:48 -0700") Message-ID: <878r9vt8fj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.150.212 X-Source-L: No X-Exim-ID: 1qafUf-0048Dr-1p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-150-212.hlrn.qwest.net (murgatroyd) [75.166.150.212]:45686 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI5kTFfRC/ZEk88R2hin4be1PmDtoFI686NBheXoZm7IW/P+gbV+9ZDwEG+VzHl4D1K/nZvssc533WMxWmmnyQNx0qxle2EaZxHEOY4Mpk11NWPssljl enh1S+Zy2sozojWVxgZ0Uv8fz6vnf9FG7Pl5gq/IWLp3rG6V3IgTPkePYLX7ykvY0aadX+9SvdEf5kLA1gBSav0m9AqsfTRJm74= X-Spam-Status: No, score=-3018.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Keith" == Keith Seitz via Gdb-patches writes: >> If it is really that dead, then -- like stabs -- I'd like to remove >> it. These dead formats just make it harder to improve gdb while not >> providing value to any user. Actually with the advent of fuzzers, >> this code now has negative value, because it wastes time coming up >> with patches to fix bugs in code no one uses. Keith> I was tempted to suggest either removing it or at least adding a Keith> --disable-reader-coff option to disable the code, but I could not Keith> convince myself that there wouldn't be relatively widespread Keith> disagreement. If we think the format is truly obsolete, then IMO it is better to just delete it. I never got back to replying about the stabs situation, but after Pedro weighed in, I think we should move ahead with that. However, we're close-ish to GDB 14 now, so I plan to wait until after that branches. The main problem for other formats is even knowing if they are in use. Searching for buildsym-legacy, I see coffread (I guess COFF had some kind of debuginfo?), dbxread (a.out but maybe stabs-like?), mdebugread (ECOFF), xcoffread (yet another COFF). My guess is that maybe only xcoffread could even be remotely relevant but I don't really know how to tell. Tom