From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id AA67F3857353 for ; Fri, 4 Aug 2023 18:04:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA67F3857353 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 0158A10047DC4 for ; Fri, 4 Aug 2023 18:04:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Rz9iqbXV66i54Rz9iq9Pjp; Fri, 04 Aug 2023 18:04:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QsWbYX+d c=1 sm=1 tr=0 ts=64cd3d96 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=UttIx32zK-AA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=6I5d2MoRAAAA:8 a=4iDQC7-nqr-hYE_hwPUA:9 a=IjZwj45LgO3ly-622nXo:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZbvO+MpKIF048HTdETCFXSHOxzhN0saODEHzQjEyzVo=; b=A+E6WyLNcRKb57qPyBDjHj5cDt cx0lO14u6qZR+aPuVjxA6JOMfMDcfM/j2dNA2vL1DEKHJieIpYqyucPdyzeVJ08oU9CZmu0sfVNTK PaJdOHhFh3chCbH//H+60mrqH; Received: from 71-211-152-221.hlrn.qwest.net ([71.211.152.221]:57566 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRz9i-0035F2-2P; Fri, 04 Aug 2023 12:04:06 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Consolidate calls to bfd_set_cacheable References: <20230804161900.384191-1-tom@tromey.com> X-Attribution: Tom Date: Fri, 04 Aug 2023 12:04:05 -0600 In-Reply-To: (John Baldwin's message of "Fri, 4 Aug 2023 09:31:44 -0700") Message-ID: <878raq8z1m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.152.221 X-Source-L: No X-Exim-ID: 1qRz9i-0035F2-2P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-152-221.hlrn.qwest.net (prentzel) [71.211.152.221]:57566 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> I think the patch seems sensible (just always marks them as cacheable in John> GDB APIs that wrap bfd_open). It might be worth explicitly noting in the John> log perhaps that the relevant functions always provide a filename (even John> if they provide an existing file descriptor) which is why it is safe to John> enable reopening. Make sense, I'll do that. John> Reviewed-by: John Baldwin I'm going to check it in now. Tom