From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 242463858CD1 for ; Mon, 31 Jul 2023 16:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242463858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34928e9f24bso2271115ab.0 for ; Mon, 31 Jul 2023 09:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1690820819; x=1691425619; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=eJ5uTtwpLLOixjGcfmdkjH3tKp+2RNJbK9uEW6ugl8Q=; b=D6a2uLxEZ1JzB2ZTroaXsTkjYi8FyfJUoe0j4vejsqweiiTYJMZgKYn3DqZha8A+aR 3a5lWHRbgrVmZpSoXci3v24Z+kIEFYSOwi0GFEcPQ1F1JdGTm2bd/gkGsB+5j1QnvEZk t531/YXHKugGcX6itRTGWkJAYLqmrnz/b2bA+Yar+E1t3zYVEwOi3vva51dOEgjLAYe1 7erkeUhIPms6nOSu+IUGTzHy2zBI7bYVyRMdbzePz/s/oI85VDjgZHtFt9RfSec9xdrG zLciGznNeCo2u+4nD2wch68NAo4wR4ZfYye7WXI98OVDGClbLrOo8S7SDl4w0Z8YvTa1 VrvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690820819; x=1691425619; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eJ5uTtwpLLOixjGcfmdkjH3tKp+2RNJbK9uEW6ugl8Q=; b=T5QkbcCEfaff4UH9l5yxpq19e/42Yw1dwkHzw6kCVICu1qZ4qvUEmLTMtVYJNVK2x7 4eVIB/Cf4ugpD7tfRBmLsMfq50GIdY1QvhK3HkeG6FAZawPCSn7dS10SIw1vnDwdvo05 V+Z9GLGifh54CuR/MNkf8w9P0CjVqtQQRpkWdz8Ny3NBIelJ46RzoxBE/kXt1sacIyuJ 6fwZry06CCkc0F2IA26wOy/0o73WoxcIrW7HPD8vUn50Zhp0trUo+oBHWE2rlMV1wY1p FrLUENHdI893wKvGceGVpL792Nt3YUi4OtpydgevxGFjNAKr84FstFvs/rFGGqRbmMB+ 0HcQ== X-Gm-Message-State: ABy/qLZTZeyYidf1IvSdAiGL7igXSngCd+5vKI5aimZUfnPiSeMIEwMj Ukyu9y9RJTcShl1AEZWk+WUIgQ== X-Google-Smtp-Source: APBJJlFlGXvfPye/Cv3H14rx+/usXbQwKq2twxG7TH8zy+mqyd6UWf1ArseUyVdXYgGLCpd/wROMQA== X-Received: by 2002:a92:c26d:0:b0:345:8373:bf68 with SMTP id h13-20020a92c26d000000b003458373bf68mr9161114ild.25.1690820818870; Mon, 31 Jul 2023 09:26:58 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id q17-20020a92c011000000b00345b34fcf34sm3272964ild.38.2023.07.31.09.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 09:26:58 -0700 (PDT) From: Tom Tromey To: Lancelot SIX Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] Full paths in DAP stackTrace responses References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> <20230725-dap-bt-path-v1-4-bb015b0d8e54@adacore.com> <20230728151539.qnrgzb37fub34tke@octopus> X-Attribution: Tom Date: Mon, 31 Jul 2023 10:26:57 -0600 In-Reply-To: <20230728151539.qnrgzb37fub34tke@octopus> (Lancelot SIX's message of "Fri, 28 Jul 2023 16:29:08 +0100") Message-ID: <878rawgi7i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> +class FrameDecorator(_FrameDecoratorBase): >> + """Basic implementation of a Frame Decorator""" >> + Lancelot> I can see that this pre-existed your patch, but is it expected to have Lancelot> two docstrings instead of one with empty lines to separate paragraphs? Nope, I've fixed it. >> @@ -172,7 +172,11 @@ def _frame_iterator(frame, frame_low, frame_high, always): >> >> # Apply a basic frame decorator to all gdb.Frames. This unifies >> # the interface. >> - frame_iterator = map(FrameDecorator, frame_iterator) >> + if always: >> + decorator = DAPFrameDecorator >> + else: >> + decorator = FrameDecorator >> + frame_iterator = map(decorator, frame_iterator) Lancelot> The purpose of always (always return an iterator) seems orthogonal to Lancelot> the way `filename()` behaves. I find this confusing. Should the Lancelot> parameter be renamed / a new parameter added? I renamed it to "dap_semantics". Tom