From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1E6453858D32 for ; Mon, 10 Jul 2023 13:45:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E6453858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688996703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZXig3PYojeb6FWAsUhExQYkp/UQs1sn9Cto9n0P6QAw=; b=YFUtzaQJFVx//GswrgW2GXUPHkn06ivD2IADqMaqV/IIE4ZvpC2W/+eIvt9uh0QZpgVrqg CTntg9U6qgeukpFWg0bFXdg7lurP/Q3BbtvaoXN264Bj/L9OklEnQtVKb/QWdBMk8rpsfM 8djm+QHE2b3sb1SoeZbxME8cztzwxaM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-cYUlgqKCNyG_QPLj2QZXyA-1; Mon, 10 Jul 2023 09:45:02 -0400 X-MC-Unique: cYUlgqKCNyG_QPLj2QZXyA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-31432b25c2fso3201966f8f.1 for ; Mon, 10 Jul 2023 06:45:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688996700; x=1691588700; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZXig3PYojeb6FWAsUhExQYkp/UQs1sn9Cto9n0P6QAw=; b=R8w6DG2ODaCX3t+RjmpFyMjaQpgPdiWCW0pQWfnFi3ugKCWdMfbj/ArKFbJ0HF3Um5 wWW8TQGFoXXmJGMbAOh6MR6qhTaqshNpCKkMFsWh8VYkcPSS7cUuwOC5k4aCS/mbajeV wcmlXN+I+NUOnKyEZvwNnBqtYlOT1uRa6jF6QyoaCmb6V4nF3mrHSVZ5Bz4XZOA3tLUo aUrG4fIjpGMxSctOO4P/GuvBvHYSOIDHQG/5qrKVRGavobKUXAGN8jUMyv7FujFW92cx u6oJqzmpakxE7sQJ61fGdyLOt6V/k/vA0jiX0aNb9X+tbOV4X4OcOTFWtfbGnO6mss7R B4qw== X-Gm-Message-State: ABy/qLY30mMt2iO+Cl/5co1xPHVsaIC2V0FnPPtiTDhgkjgdROIAU1uI tyYkkoYAtxZOprQbnO0k+Rm3vMR3KzTbT/pA7K00bsmmPB6z4S5RAxQb92UdG77o1DQ3oE5J8Rh Op5MiLsg+jLKUoHEbJKhftVzpQbmhyQ== X-Received: by 2002:a5d:684e:0:b0:315:8fbc:4dd with SMTP id o14-20020a5d684e000000b003158fbc04ddmr8681067wrw.50.1688996699988; Mon, 10 Jul 2023 06:44:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlEXDwvsUC9Sh2Rx+rfPvEc+3n7vrwkeeZJIoMFT6EShjHf4exsQPrVOkRLJzerp31FERKO6BQ== X-Received: by 2002:a5d:684e:0:b0:315:8fbc:4dd with SMTP id o14-20020a5d684e000000b003158fbc04ddmr8681052wrw.50.1688996699709; Mon, 10 Jul 2023 06:44:59 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id t11-20020a5d6a4b000000b00311299df211sm11775993wrw.77.2023.07.10.06.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 06:44:59 -0700 (PDT) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCHv5 03/11] gdbserver: allow agent expressions to fail with invalid memory access In-Reply-To: References: <0ef54ed920e1262a07f4a061ecc08bea8fcaee23.1678987897.git.aburgess@redhat.com> <01059f8a-0e59-55b5-f530-190c26df5ba3@palves.net> <87pm53k7om.fsf@redhat.com> <2d33fb4e-380a-310c-d4b4-cf3dfe69eaec@palves.net> <87edlgjbul.fsf@redhat.com> Date: Mon, 10 Jul 2023 14:44:58 +0100 Message-ID: <878rbnkhid.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > On 2023-07-10 11:32, Andrew Burgess wrote: > >> commit 75a86840a474097a19f4d04c9232981df3bf8066 >> Author: Andrew Burgess >> Date: Fri Jul 7 17:18:46 2023 +0100 >> >> gdbserver: handle all eval_result_type values in tracepoint.cc > > ... > > >> +/* The AX_RESULT_TYPE macro is used to define a result type that can be >> + generated by agent expression evaluation. The first macro argument is >> + tye name of an enum entry, and the second is a string that describes > > Typo: "tye" -> "the" Fixed. > > Otherwise, > > Approved-By: Pedro Alves Pushed. Thanks, Andrew