From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E05FB3858D28 for ; Mon, 3 Jul 2023 16:25:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E05FB3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688401519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6TZjWrf2TMhk3D/XBNdfHubEQT9+wC+reAEkHJqnmCM=; b=g25//kQOhCi4UfVXqX1Og/0Q8GPI7XVjbuW6lbYrudDlbfBxrYEwt7KeYjAQqa/qUabT36 EIc/DDrlDH9Qo0+oP+YNC4o/gGlWUTbvuL3OBmh7NS/ma8+g7Tk49wFXa0BMWqUjX74ePZ iYCQbz3IyQF5cGZhWvHjVd3NJar2B3c= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-ykrziaS1NheHeBzqLIl9Xw-1; Mon, 03 Jul 2023 12:25:18 -0400 X-MC-Unique: ykrziaS1NheHeBzqLIl9Xw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f5fa06debcso32677535e9.0 for ; Mon, 03 Jul 2023 09:25:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688401517; x=1690993517; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6TZjWrf2TMhk3D/XBNdfHubEQT9+wC+reAEkHJqnmCM=; b=iwHE2ezfS7LkO7sNDLStdL7O+268nkASEjazt0eW/ctVPiM5XLvoUnNSEAbb2Lmyfg fS80IFlzjTz+CX8bDQdoCoM/CFPd1e0k8/1ifnBqDGZZcQ9TNPXAbrZ76tCdfX0daAh5 /WaFGJ00wR/34vhPA59oa1rLJmVhoTGpI1PbGQxAoQuNNdiVyss+4AFB2ZJ5n+rFENMm HqH49pABgI3FOY6GG/Rn+VoPRUnMP5XpHOe3lhv4ELGIBUnZo2T49m5eMe4LnLiyg306 tc4IT+IzAbXcFF4nGIgDM2V90F1e0dcXY2efAtcH3yqdQWiNmqv+pRpuO3N86ZALsbdS +/Ug== X-Gm-Message-State: AC+VfDy2Q8x742xIBnf4OjPtHjH7p1AKmossce0FXR2CsHo3QBci2ml4 DCzYp+2P1xIn2PE7BiCNhjAFWxvqmj4WS5LPn+9KwWyGFFVRcKcuf0V6afPs7/1zJUm5TcUm8Ao q/B7WbDK6pWENjAPD1gejj4IsWc0rsA== X-Received: by 2002:a7b:c5d0:0:b0:3f6:a65:6ff3 with SMTP id n16-20020a7bc5d0000000b003f60a656ff3mr10063519wmk.32.1688401517311; Mon, 03 Jul 2023 09:25:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5+yvijDTFNcY0nkMTSI3nREqh2N3moNbAbOPxEmDu8wdkQ4X2gR6YM/W++s4EvHZExU83F/w== X-Received: by 2002:a7b:c5d0:0:b0:3f6:a65:6ff3 with SMTP id n16-20020a7bc5d0000000b003f60a656ff3mr10063501wmk.32.1688401516880; Mon, 03 Jul 2023 09:25:16 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003f90a604885sm27499159wma.34.2023.07.03.09.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 09:25:16 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Cc: pedro@palves.net, kevinb@redhat.com, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org, Bruno Larsen Subject: Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS In-Reply-To: <20230628124205.1604307-3-blarsen@redhat.com> References: <20230628124205.1604307-2-blarsen@redhat.com> <20230628124205.1604307-3-blarsen@redhat.com> Date: Mon, 03 Jul 2023 17:25:15 +0100 Message-ID: <878rbxm07o.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno Larsen writes: > The project has been using Tested-By (tb), Reviewed-By (rb) and > Approved-By (ab) for some time, but there has been no information to be > found in the actual repository. This commit changes that by adding > information about all git trailers to the MAINTAINERS file, so that it > can be easily double-checked. > > The upstream discussion also brought up the use of Acked-by, which is > better defined in this commit. Finally, for completeness sake, the > trailers Co-Authored-By and Bug were added, even though they have been > in use for some time already > --- > gdb/MAINTAINERS | 66 +++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 58 insertions(+), 8 deletions(-) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 7fa608fd82c..cd9d299ea42 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes > patches which change internal interfaces (e.g. global functions, data > structures) or external interfaces (e.g. user, remote, MI, et cetera). > > -The term "review" is used in this file to describe several kinds of feedback > -from a maintainer: approval, rejection, and requests for changes or > -clarification with the intention of approving a revised version. Review is > -a privilege and/or responsibility of various positions among the GDB > -Maintainers. Of course, anyone - whether they hold a position but not the > -relevant one for a particular patch, or are just following along on the > -mailing lists for fun, or anything in between - may suggest changes or > -ask questions about a patch! > +The word "contributor" is used in this document to refer to any GDB > +developer listed above as well as folks who may have suggested some > +patches but aren't part of one of those categories for any reason. > > There's also a couple of other people who play special roles in the GDB > community, separately from the patch process: > @@ -78,6 +73,61 @@ consensus among the global maintainers and any other involved parties. > In cases where consensus can not be reached, the global maintainers may > ask the official FSF-appointed GDB maintainers for a final decision. > > +The term "review" is used in this file to describe several kinds of > +feedback from a maintainer: approval, rejection, and requests for changes > +or clarification with the intention of approving a revised version. > +Approval is a privilege and/or responsibility of various positions among > +the GDB Maintainers. Of course, anyone - whether they hold a position, but > +not the relevant one for a particular patch, or are just following along on > +the mailing lists for fun, or anything in between - may suggest changes, ask > +questions about a patch or say if they believe a patch is fit for upstreaming! > + > +To ensure that patches are only pushed when approved, and to properly credit > +the contributors who take the time to improve this project, the following > +trailers are used to identify who contributed and how. All patches pushed > +upstream should have at least one Approved-By patches (with the exception of > +obvious patches, see below). The trailers (or tags) currently in use are: > + > + - Acked-By: > + > + Used when a contributor has taken a quick glance at a patch and agrees > + with the direction outlined in the commit message, but hasn't evaluated > + the code for correctness or regressions. > + > + - Tested-by: > + > + Used when a contributor has tested the patch and finds that it > + fixes the claimed problem. It may also be used to indicate that > + the contributor has performed regression testing. By itself, this > + tag says nothing about the quality of the fix implemented by the > + patch. Given the number of different ways that tests can be run, and that you specifically say "It _may_ also be used to indicate ...", I wonder if it's worth extending the last sentence to specifically say: By itself, this tag says nothing about the quality of the fix implemented by the patch, nor the amount of testing that was actually performed. Some people might give a (tb) tag just for running the tests added by the commit in question, while others might run the full testsuite on a unix board, while others might do a full regression test using multiple different boards. The tag itself tells us very little really. Thanks, Andrew > + > + - Reviewed-by: > + > + Used when a contributor has looked at code and agrees with the > + changes, but either doesn't have the authority or doesn't feel > + comfortable approving the patch. > + > + - Approved-by: > + > + Used by responsible maintainers or global maintainers when a patch is > + ready to be upstreamed. Some patches may touch multiple areas and > + require multiple approvals before landing (such as a maintainer only > + approving documentation), it is up to the maintainer giving the approval > + tag to make it clear when that a tag is not sufficient. Responsible, > + Global and Official FSF-appointed maintainers may approve their own > + patches, but it is recommended that they seek external approval before > + doing so. > + > + - Co-Authored-By: > + > + Used when the commit includes meaningful conrtibutions from multiple people. > + > + - Bug: > + > + This trailer is added with a link to the GDB bug tracker for added context > + on relevant commits. > + > > The Obvious Fix Rule > -------------------- > -- > 2.41.0