From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id BD0483858C2C for ; Wed, 28 Jun 2023 15:49:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD0483858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-345c1ed760aso6659165ab.1 for ; Wed, 28 Jun 2023 08:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687967356; x=1690559356; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aAnoiLm1IKF4zZjA9bdncPQPcKu7I/FKFceTGPXQU2U=; b=YnxlFYcdWTv5IDZz4Zy/rcj4IXniSqO8XhblFNpKTXlhTevP23mtcE1E8WlCnUfcFD cs1iMqColRdY71yFudd5MEibnWETC/BB01tlWdTanf4c0wWvJVWpoiBu/2wheUc89Pb9 8WMaGif844LbwuwES/pssxYGcDtZ82/iB6JTAicjZeujpnFSsdBjv6fp3Iwf0kgvHakz 1T4zCV9oEclKrjwFF9/EKz1x1GOx3e0PK4SVr1HeDcdkn9IlBjLvsnHDtz5NpmMoQ8ZJ 9o/ARwwT/HPEAFlAIJ1DK+ELUnughH5aQ9Z9vammGyk7FWHfLShLJHCploobM9+hni9u JJ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687967356; x=1690559356; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aAnoiLm1IKF4zZjA9bdncPQPcKu7I/FKFceTGPXQU2U=; b=HtEO7wT7/IhVwnrb0ok5fUb6ZUZuGvjoB6Ddo3JdpcMBMoL/kCihU8Wgzw/XSKsYOx 1Wi1lhvz0Fka5TQ9p5MG3fls/XqRqdoptvX0QYHD2z14dXXUefKqQ4i+cvPWaQZmjaep PyXxHzw2fmGL2lHAvHBa0HEReXSLcJX5rYAu++ylu/j/fev96bUsgx9OElAh6CrRy1Yy P9odbOSFXAwkJEE1A5GwJQDey7IzKrlq87TAtMAhnCyM8sPLEtgc2ECYwIdIQd8EtGA2 y+gDiITJ7BArA5NzSrVFBySIQP1qgarBIy22vUjiQQ6EmwL244Uf8vcicPebpCB/MQfx M6Dw== X-Gm-Message-State: AC+VfDyfFsrxkS39EnXrvTWR3rNQty1OxwxdsJGNlYobbv/c5QLz3klH 0Vg9iY67IxjQI9GfrPgj8lFuTvqTeRbGA4GTOjEecg== X-Google-Smtp-Source: ACHHUZ4NjwHYsFKRBpTPLSdSyNVJDA5CHqKXQhZ/Cs3nUxy8xjx17KE1VMJvTpMvJqYonZAyYnHr5A== X-Received: by 2002:a92:1308:0:b0:345:c1cb:864d with SMTP id 8-20020a921308000000b00345c1cb864dmr3708844ilt.23.1687967355845; Wed, 28 Jun 2023 08:49:15 -0700 (PDT) Received: from murgatroyd (71-211-136-248.hlrn.qwest.net. [71.211.136.248]) by smtp.gmail.com with ESMTPSA id s14-20020a92cc0e000000b00345b34fcf34sm1558737ilp.38.2023.06.28.08.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 08:49:15 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix handling of DW_TAG_unspecified_type for Ada References: <20230615130332.2447095-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 28 Jun 2023 09:49:14 -0600 In-Reply-To: <20230615130332.2447095-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 15 Jun 2023 07:03:32 -0600") Message-ID: <878rc3y4cl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> Commit 80eaec735e ("[gdb/symtab] Handle named DW_TAG_unspecified_type Tom> DIE") changed the handling of DW_TAG_unspecified_type. Before this Tom> change, such types were not entered into the symbol table. Tom> It turns out that, when such a type is in the symtab, it can cause Tom> failures in Ada. In particular, a private type in another package may Tom> be seen locally as "void". Tom> Now, it would probably be better to fix this via check_typedef. Tom> However, that is somewhat difficult given the state of the DWARF Tom> reader -- in particular with gdb_index, this would require expanding Tom> potentially many CUs to find the correct type. Tom> Instead, this patch changes gdb to not enter a symbol for an Tom> unspecified type -- but only for Ada. I'm checking this in. Tom