public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Make MI commands const-correct
Date: Thu, 25 May 2023 19:00:15 -0600	[thread overview]
Message-ID: <878rdbuctc.fsf@tromey.com> (raw)
In-Reply-To: <6aec61f9-fda3-61ed-399f-661220e0741f@simark.ca> (Simon Marchi's message of "Thu, 25 May 2023 11:50:43 -0400")

>> I've had this patch for a while now and figured I'd update it and send
>> it.  It changes MI commands to use a "const char * const" for their
>> argv parameter.

Simon> I didn't read all the patch, but if all you do is add some const, and it
Simon> builds, I don't really see how it can break things.

Simon> Acked-By: Simon Marchi <simon.marchi@efficios.com>

Thanks, I'm going to check it in.

Tom

      reply	other threads:[~2023-05-26  1:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 14:44 Tom Tromey
2023-05-25 15:50 ` Simon Marchi
2023-05-26  1:00   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rdbuctc.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).