From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B17C738582AB for ; Wed, 10 May 2023 13:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B17C738582AB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683724403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j1bzlz9EhEuFQmGSTc++uUzzZwgruLFCia1kE6fTADE=; b=S+Dh0NiT0/4gM9kT06JFzzS/+r7Sr+NEeTTXy7nnvOsolDq9VsIRk3zROZBESbR1z1LNLv wep/Km0DqZthhnzs60z9Kv/cb+WaqnBm9yT8QF0lAiuz2oACOvdp4Ph27bW0bSNWpfz2Gd QIIR4T2fowl9pHNz/q5DWh+gBMWoY8o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-bcPoFCI0PfiJzZfi-u1a0A-1; Wed, 10 May 2023 09:13:22 -0400 X-MC-Unique: bcPoFCI0PfiJzZfi-u1a0A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f33f8ffa05so44343765e9.1 for ; Wed, 10 May 2023 06:13:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683724401; x=1686316401; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j1bzlz9EhEuFQmGSTc++uUzzZwgruLFCia1kE6fTADE=; b=Y+kG4lrCWfXRT8NX0ODHPS/BVuoz4F44PUnTol7p7V/yfyaHMAJRYajX3ydtwnsb7a 6tr+Rb8OiYJU2WrWX/UjHP11O3+XwENvpIhBKcJpCCrj97WSHA5vb4QVHXlYbxKb2FSp 5VYb6n4qsC4n6JwKSIv13bL2H6F6+oh9Sf7o/5jirxiN1YguzIb2rFzotiGC/y7NVS/i XmzcZEbtwIwTDE9iXGqwWbj3IQeitWERCpTwHcYeGoUoYwEsvy94WkqOmx8PVdQIVLPy 3yEmaDWcvEXf66dV7vz7St+KdnHBKpOTN+8inPifASjX7wh+tPq9y7YfhVTJNJi2xP6J Dcwg== X-Gm-Message-State: AC+VfDxdS4LFrqmlFlrqNTWAQPunUjGl4T7XbJkKEN1nFUpTdKzHRTKi ap9AEsPGDiKK32C4LauH0d+JnX1qomkx4ABQI3ioZwPq4ppuZTR97YAZCEOkdLCYBzeNGmVMWcN 8fuT2boesgAi8prBkRbMdXFAj4YVtoRd2sqcLxmB2fGU/wOlzW+0CedwfbHagl+KaMtnAmbr8D2 HcGu9Dzg== X-Received: by 2002:a05:600c:2257:b0:3f4:2b98:428f with SMTP id a23-20020a05600c225700b003f42b98428fmr4076732wmm.39.1683724400804; Wed, 10 May 2023 06:13:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ401vXgZwfY22trxH8KaLdKPM7F1yEU680IzNU7B1C+mC8nAublC2+LHPxI5GYsioLWaK/THQ== X-Received: by 2002:a05:600c:2257:b0:3f4:2b98:428f with SMTP id a23-20020a05600c225700b003f42b98428fmr4076713wmm.39.1683724400380; Wed, 10 May 2023 06:13:20 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id z22-20020a7bc7d6000000b003f42813b315sm7400029wmk.32.2023.05.10.06.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 06:13:19 -0700 (PDT) From: Andrew Burgess To: Richard Bunt via Gdb-patches , gdb-patches@sourceware.org Cc: Richard Bunt , Josh Cottingham Subject: Re: [PATCH] gdb/mi: Fix printing of fortran strings in stack In-Reply-To: <20230510102031.2125810-1-richard.bunt@linaro.org> References: <20230510102031.2125810-1-richard.bunt@linaro.org> Date: Wed, 10 May 2023 14:13:18 +0100 Message-ID: <878rdw72j5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Bunt via Gdb-patches writes: > 547ce8f00b4ef826bdc9bf9a74f119fe9768852e fixed an issue where dynamic > types were not being resolved correctly prior to printing a value. The > same issue was discovered when printing the value using MI-mode. Solved > by porting the fix to the MI mode code path. > > GDB built with GCC 13. > > No test suite regressions detected. Compilers: GCC 12.1.0, ACfL 22.1, > Intel 22.1; Platforms: x86_64, aarch64. > > Co-Authored-By: Josh Cottingham Thanks for fixing this. Looks good to me. Approved-By: Andrew Burgess Thanks, Andrew > > --- > gdb/mi/mi-cmd-stack.c | 3 +++ > gdb/testsuite/gdb.fortran/mixed-lang-stack.exp | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/gdb/mi/mi-cmd-stack.c b/gdb/mi/mi-cmd-stack.c > index 0172bf9814d..70762880c49 100644 > --- a/gdb/mi/mi-cmd-stack.c > +++ b/gdb/mi/mi-cmd-stack.c > @@ -590,6 +590,9 @@ list_args_or_locals (const frame_print_options &fp_opts, > > ui_out_emit_list list_emitter (uiout, name_of_result); > > + scoped_restore_selected_frame restore_selected_frame; > + select_frame (fi); > + > while (block != 0) > { > for (struct symbol *sym : block_iterator_range (block)) > diff --git a/gdb/testsuite/gdb.fortran/mixed-lang-stack.exp b/gdb/testsuite/gdb.fortran/mixed-lang-stack.exp > index 6ab3f8adeba..5fc36f7b95b 100644 > --- a/gdb/testsuite/gdb.fortran/mixed-lang-stack.exp > +++ b/gdb/testsuite/gdb.fortran/mixed-lang-stack.exp > @@ -92,6 +92,18 @@ proc run_tests { lang } { > } > } > > + # Check backtrace arguments in MI mode. > + set mi_a "\{name=\"a\",value=\"1\"\}" > + set mi_b "\{name=\"b\",value=\"2\"\}" > + set mi_c "\{name=\"c\",value=\"3\"\}" > + set mi_d "\{name=\"d\",value=\"\\(4,5\\)\"\}" > + set mi_e "\{name=\"e\",value=\"$e_arg\"\}" > + set mi_g "\{name=\"g\",value=\"\\( a = 1.5, b = 2.5 \\)\"\}" > + # Hidden argument name changes depending on compiler. > + set mi_hidden "\{name=\"\[^\r\n\]+\",value=\"6\"\}" > + gdb_test "interpreter-exec mi '-stack-list-arguments --no-frame-filters --all-values 7 7'" \ > + "\\^done,stack-args=\\\[frame=\{level=\"7\",args=\\\[$mi_a,$mi_b,$mi_c,$mi_d,$mi_e,$mi_g,$mi_hidden\\\]\}\\\]" > + > # Check the language for frame #0. > gdb_test "info frame" "source language fortran\..*" \ > "info frame in frame #0" > -- > 2.32.0