From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id DAB8C3858D35 for ; Fri, 5 May 2023 19:53:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAB8C3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-763c3429a8cso56797039f.2 for ; Fri, 05 May 2023 12:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1683316392; x=1685908392; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=RlCmpPP1vo7Zv3CZ1NNPIylvS5LAZRaZ4GA7YOPu4OY=; b=eqLryc2RxRYYA60TYmzwQwrtdm/W7BmSXCezfjXO69fP4dJog0njhn5H4r3/jr8/TE iwG0qCY9JMC94H2O7E0j3Bk83AvMsbk7ETyZAxYQdlRcFQP+fJkqSJO1MC7xOiozc6pl A7o2kTw18o651bRVuh7BNnUr5Rs9UaG73/pyMu3u8zF6WsCHDbD71NhEwpS1x+uKs0E3 zYQLQWFT2sG9Z1nESZuIauQ4dYOyIvjs8od6F57biZiB/oa2Jjn0cORkDRlnLk6hq8B+ +UZ2dI0jmHVuhACOclLMNX5cBUqvo0UpqF234SzLcPerEEdVFcpSydXuJrEImjIBUkBH vsbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683316392; x=1685908392; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RlCmpPP1vo7Zv3CZ1NNPIylvS5LAZRaZ4GA7YOPu4OY=; b=i5PC5Zh+G2lClXx71DzBL4TpjuGoJeezlR3pL674duRAEIgxQwr1q7zFAYjBWcwemh qCC+3tq2seAbj04Dji1I5AWjcEvZ5P1GammxMg2o9dhDFKrNUhnQX3oEfFOpbj8s6hhK VZkFYeyNvhrx99FeTwMJHeUJYRYG5D8r7pr2yYY+zOzcjYdOMGMWdCesCHuWch62VavP q1H0MaA8Wn26blUXGZnuu/XEGEH8VIw6rHspccUZG09Ae25wuSpux9Vq5D0v6lsFzl2A QYv/gBhecYk1Qc/A5HsDjMYriE33DusGNdEbRebKtA218LpAGg/HukI0PGPh/HpAFqkZ UZiw== X-Gm-Message-State: AC+VfDyTeMgitYXHK04EUV5e3H2wYBzOrk/AIrzd9IjbC7TYih1RUpnT KGrImoOIPtRy9tAWGVSJkWnQ4w== X-Google-Smtp-Source: ACHHUZ6dkhjD5qJi7IvNLWFum+F3vys0BYaFjr8HNogHeKA2QsI5XzXM73kqLgwd4DbiY4aUFeBM9g== X-Received: by 2002:a05:6602:58:b0:768:dd79:c013 with SMTP id z24-20020a056602005800b00768dd79c013mr1635700ioz.17.1683316392089; Fri, 05 May 2023 12:53:12 -0700 (PDT) Received: from murgatroyd (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id m19-20020a056638271300b0041456ef4168sm156810jav.119.2023.05.05.12.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 May 2023 12:53:11 -0700 (PDT) From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use discrete_position in ada-valprint.c References: <20230427172953.3057526-1-tromey@adacore.com> <115bf68b-5335-023b-c223-90caf0b13e4d@redhat.com> X-Attribution: Tom Date: Fri, 05 May 2023 13:53:11 -0600 In-Reply-To: <115bf68b-5335-023b-c223-90caf0b13e4d@redhat.com> (Keith Seitz's message of "Fri, 5 May 2023 12:43:21 -0700") Message-ID: <878re2sggo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Keith" == Keith Seitz writes: Keith> On 4/27/23 10:29, Tom Tromey via Gdb-patches wrote: >> I found a couple of spots in ada-valprint.c that use an explicit loop, >> but where discrete_position could be used instead. Keith> Nice cleanup. Learn something new everyday! Thanks, I've checked it in. Tom