From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 552333858D28 for ; Tue, 2 May 2023 15:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 552333858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id C0FC810042E2C for ; Tue, 2 May 2023 15:15:04 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id triapvdjYlj3Atriapeu0k; Tue, 02 May 2023 15:15:04 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XsY/hXJ9 c=1 sm=1 tr=0 ts=645128f8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=Xa3HRzG6Me-oc47eS90A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LVG1PAAzbnwkmG5LLonlUKUy5EvE2jn9KLA4gxkTd4U=; b=gWX5vC5eqwNn5FSd4xBgzIAL3Z SwJ6VGPLSRLHJiP5P26+Qr1qywwFMVEIU7Th6msTdSaYenZoVrwx4YXG47M5Q568+bxiGTHAFgxlR YK3r5QVJJAno9o9AgDv8dIsy9; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:55482 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ptria-002p2X-6n; Tue, 02 May 2023 09:15:04 -0600 From: Tom Tromey To: Alexandra Petlanova Hajkova via Gdb-patches Cc: Tom Tromey , Alexandra Petlanova Hajkova Subject: Re: [PATCH] Remove error_stream References: <20230416184833.391586-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 02 May 2023 09:15:03 -0600 In-Reply-To: (Alexandra Petlanova Hajkova via Gdb-patches's message of "Mon, 17 Apr 2023 12:55:16 +0200") Message-ID: <878re6vk7c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1ptria-002p2X-6n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:55482 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Alexandra" == Alexandra Petlanova Hajkova via Gdb-patches writes: >> error_stream is trivial and only used in a couple of spots in >> breakpoint.c. This patch removes it in favor of just writing it out >> at the spots where it was used. Alexandra> I was considering using it in my "defer warnings when loading separate Alexandra> debug file" but it wasn't suitable, it seems it doesn't have many use cases Alexandra> indeed. Thanks for the note. I'm going to check this in now. Tom