From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 896B53858D39 for ; Sun, 30 Apr 2023 19:15:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 896B53858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id C8F8210047D93 for ; Sun, 30 Apr 2023 19:15:15 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id tCVvpUxM4xoCutCVvpF8Ht; Sun, 30 Apr 2023 19:15:15 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BOt2EHcG c=1 sm=1 tr=0 ts=644ebe43 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=75FAf6A6GYzAqeeAwkAA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YLTJiHSDvtFNfVq14i0M5+ilsoHq1sMv+xmDzIXUEA0=; b=glZuZHxjSD3j60pg73Ztj5HrsE +O/GX4/irTuYvn2UPWyLCn5ZovgheyyI2CMOxTXwsBXbDrQ+wILLo8UQG/awVum4M0/W/b3Nu+ePm PBfRnh0ev9eXadPGLofZsx8Pi; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:42358 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ptCVv-004OMu-ED; Sun, 30 Apr 2023 13:15:15 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [pushed] [gdb/tui] Fix TUI resizing for TERM=ansi References: <20230430110647.975-1-tdevries@suse.de> X-Attribution: Tom Date: Sun, 30 Apr 2023 13:15:13 -0600 In-Reply-To: <20230430110647.975-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Sun, 30 Apr 2023 13:06:47 +0200") Message-ID: <878re9mbb2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1ptCVv-004OMu-ED X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (prentzel) [71.211.191.82]:42358 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> As it happens, when TERM is set to ansi, readline decides that the terminal Tom> cannot auto-wrap lines, and reserves one column to deal with that, and as a Tom> result reports back one less than the actual screen width: ... Tom> This is currently not causing trouble in testing because we have a workaround Tom> in place in proc Term::resize. If we disable the workaround: Thank you for tracking this down. I never even considered this might be a readline issue. Tom> + readline_hidden_cols = _rl_term_autowrap ? 0 : 1; I hate to have a new dependency on a readline internal variable. Don't some distros mark these as hidden in libreadline.so? I feel like there was another bug along these lines. However, I don't see another way to do it. Maybe some official API could be added by the upstream readline. Would you want to bring it up there? Anyway it seems ok to me. thanks, Tom