From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy1-pub.mail.unifiedlayer.com (qproxy1-pub.mail.unifiedlayer.com [173.254.64.10]) by sourceware.org (Postfix) with ESMTPS id 017FF3858D1E for ; Tue, 25 Apr 2023 18:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 017FF3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy1.mail.unifiedlayer.com (Postfix) with ESMTP id 21FF7802DA01 for ; Tue, 25 Apr 2023 18:40:25 +0000 (UTC) Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id CECEA1003E90E for ; Tue, 25 Apr 2023 18:38:49 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id rNYvpxHPVUwlvrNYvpY3D1; Tue, 25 Apr 2023 18:38:49 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BbEdbph2 c=1 sm=1 tr=0 ts=64481e39 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=w8NMwYRv1nSRkPWOEk0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G4RF8cIGBCYlR5Cqu9DH7GWOiGKRNKFjdPoBiU0bGR0=; b=rHUh8bLaSWxlECE4LlAKuhzlRb 27Hu0iUSkF/EDds7JW3rZB8eXTUESTwCm4/fJwPgaxOyTpq2p3M3jncb0072Krmvey8K2BcGdTm/8 WJBe+8Iu6zDh8yqWI1LepeXAd; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:59094 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1prNYv-0046DH-A3; Tue, 25 Apr 2023 12:38:49 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom Tromey , Tom de Vries Subject: Re: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp References: <20230424124846.29580-1-tdevries@suse.de> <874jp5z0n8.fsf@tromey.com> <2a3587b4-98c4-263a-7deb-9530fbf06c57@suse.de> X-Attribution: Tom Date: Tue, 25 Apr 2023 12:38:48 -0600 In-Reply-To: <2a3587b4-98c4-263a-7deb-9530fbf06c57@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 24 Apr 2023 22:22:44 +0200") Message-ID: <878refyfgn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1prNYv-0046DH-A3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:59094 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> +set sources [lmap i $sources { subst $srcdir/$subdir/$i }] Tom> My working set of tcl is a bit random, so I don't know what idiomatic Tom> is and what not. No worries, Tcl expertise isn't exactly a headline skill. Tom> I agree that subst is neater since it needs less quoting. It probably has to be { subst { $srcdir/$subdir/$i } } since otherwise there will be a second substitution if, say, the srcdir has a $ or [] in it. Tom