From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 1C1073858C50 for ; Tue, 28 Mar 2023 21:23:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C1073858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 7BC511004BBB6 for ; Tue, 28 Mar 2023 21:23:20 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id hGmmpNQ7yjdlqhGmmprPQX; Tue, 28 Mar 2023 21:23:20 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=OfddsjfY c=1 sm=1 tr=0 ts=64235ac8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=6shCvtZHVibMAib5zfUA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=syJJXZV0rWO+cLwdKnqWZMTF+pZCBbXZ4aPGDVLnaO8=; b=eVPCG7N8BHuKAb6oshPeU2igKI TQdw3CE0u8ptqExYFpKmSi2gvNWQZxINbWNE5QnBJMUtM++Iw9vQPk9MmoHOs2jstQ8n52gGuuMSl Cmyh3Jv+Y8BXOnxz/IZRuwsZW; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:49162 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1phGmm-000Hik-15; Tue, 28 Mar 2023 15:23:20 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] Use unrelocated_addr in minimal symbols References: <20230321-submit-unrelocated-type-v1-0-2a1fb6117abf@tromey.com> <20230321-submit-unrelocated-type-v1-5-2a1fb6117abf@tromey.com> X-Attribution: Tom Date: Tue, 28 Mar 2023 15:23:15 -0600 In-Reply-To: (Simon Marchi's message of "Tue, 28 Mar 2023 09:46:09 -0400") Message-ID: <878rfg7epo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1phGmm-000Hik-15 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (prentzel) [71.211.185.113]:49162 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> On 3/21/23 15:18, Tom Tromey wrote: >> This changes minimal symbols to use unrelocated_addr. I believe this >> detected a latent bug in add_pe_forwarded_sym. Simon> Given the time I have right now, I just looked at a subset of the Simon> changes, it looks fine to me. Thanks. I'm going to check it in. Simon> On thought I had is that the frob_address function (from minsyms.c) Simon> would be a good candidate to become a general-purpose Simon> objfile::unrelocate method (for those callers that don't know the Simon> section index). I didn't do this yet but I suppose I could. Tom