From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id A2AD53858C54 for ; Tue, 28 Mar 2023 19:26:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2AD53858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 065681003BE07 for ; Tue, 28 Mar 2023 19:26:41 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id hExspM9jEjdlqhExspq9ie; Tue, 28 Mar 2023 19:26:41 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=OfddsjfY c=1 sm=1 tr=0 ts=64233f71 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=13KGAo4DAAAA:8 a=pz2vebpzbKDMJppI-ucA:9 a=DdAeqqNASC6T8jxox_Jq:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JDQdRzmnWJZqX8muOqL9AC9/ifN2mZaA3sua4Djw46E=; b=I7120CIyiDaorLMOz+1989y85Q LHcsdQdTYyTh7paOIWxyfQO/jACoIkD2iMK0eq1mt6URBJ4QJmPpBjrMP8zbS56bNoA3/GOIh7gVX 6A2ysJqFdLTbz7ZdRsukdkVm5; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:51906 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1phExs-002rIT-Hn; Tue, 28 Mar 2023 13:26:40 -0600 From: Tom Tromey To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Richard Bunt Subject: Re: [PATCH v2 2/3] GDB: Bring back the handling of DW_CC_program References: X-Attribution: Tom Date: Tue, 28 Mar 2023 13:26:36 -0600 In-Reply-To: (Maciej W. Rozycki's message of "Tue, 28 Mar 2023 19:48:42 +0100 (BST)") Message-ID: <878rfgd6dv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1phExs-002rIT-Hn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (murgatroyd) [71.211.185.113]:51906 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3017.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Maciej" == Maciej W Rozycki writes: Maciej> Original code was removed with commit 6209cde4ddb8 ("Delete DWARF Maciej> psymtab code"), and then an update to complement commit 81873cc81eff Maciej> ("[gdb/symtab] Support DW_AT_main_subprogram with -readnow.") has also Maciej> been included here. Sorry about that. Maciej> NB this was discovered with and is covered by the test case included with Maciej> 3/3; it has been verified to trigger with GCC 4.4.7 and will likely also Maciej> with other configurations. Maciej> +/* Return TRUE if the given DIE is the program's "main". */ Maciej> + Maciej> +static bool Maciej> +dwarf2_func_is_main_p (struct die_info *die, struct dwarf2_cu *cu) Maciej> +{ Maciej> + if (dwarf2_flag_true_p (die, DW_AT_main_subprogram, cu)) Maciej> + return true; Maciej> + struct attribute *attr = dwarf2_attr (die, DW_AT_calling_convention, cu); Maciej> + return (attr != nullptr Maciej> + && attr->constant_value (DW_CC_normal) == DW_CC_program); Should the DW_AT_calling_convention thing only apply to Fortran CUs? I have only ever heard of this approach being used by Fortran compilers. Maciej> + case DW_AT_calling_convention: Maciej> + if (attr.constant_value (DW_CC_normal) == DW_CC_program) Maciej> + *flags |= IS_MAIN; Both the spots doing this check could probably use a comment explaining why. Maybe someday we'll get to remove this again. Tom