From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 98C463858C2C for ; Tue, 7 Mar 2023 19:20:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98C463858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id F1477100563D1 for ; Tue, 7 Mar 2023 19:20:22 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id ZcrGpf8fkBwvKZcrGpkwOS; Tue, 07 Mar 2023 19:20:22 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Jqk0EO0C c=1 sm=1 tr=0 ts=64078e76 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=WCMcZr49-CfFWfqgDmMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rFDuQFMoIu/23vScAvhEcyfvbtJ6F5BjUmSrtEGGulI=; b=rWvJByWe2D5trlceimZ3Glqkmm FTcIiclFBWRVaSqaRggfn3xSfp/QxfPliS4StdACpICJ3M8xe+j+s820kVNifp7wO31fM1o/QVq+e jYC3jzMHvVW1fldDTGI1i6Qry; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:53676 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZcrG-000ir2-HV; Tue, 07 Mar 2023 12:20:22 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Lancelot SIX , Simon Marchi Subject: Re: [PATCH] gdb/amdgpu: provide dummy implementation of gdbarch_return_value_as_value References: <20230306214650.1744872-1-simon.marchi@polymtl.ca> <20230307104556.6irap5z2epv7ppxq@ubuntu.lan> <5f905345-15a1-d7e0-f8b5-221997fcd1ac@polymtl.ca> X-Attribution: Tom Date: Tue, 07 Mar 2023 12:20:18 -0700 In-Reply-To: <5f905345-15a1-d7e0-f8b5-221997fcd1ac@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 7 Mar 2023 09:47:15 -0500") Message-ID: <878rg8s70t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZcrG-000ir2-HV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:53676 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I think that Pedro hinted that we would need this anyway at some point, Simon> for functions that don't follow a defined ABI. So, I think it would Simon> make sense, but we need to update the core of GDB to handle that Simon> response. Can we even detect this situation? E.g., PR 30090 turned out to have a function with a nonstandard ABI, and in the end I just xfail'd the test. Simon> And I'm not too familiar with this area, so I don't know how Simon> much work this represents. But if we know we're going to need this Simon> anyway, I might as well give it a shot. There aren't many callers of the gdbarch hooks so I guess you could just track them all down and see what needs to be done at each one. There's definitely already code to handle the lack of a return value, so it seems like it may not be too hard. Tom