From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by sourceware.org (Postfix) with ESMTPS id D99263858039 for ; Fri, 27 Jan 2023 15:13:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D99263858039 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd31.google.com with SMTP id k3so455470ioc.10 for ; Fri, 27 Jan 2023 07:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rVQNxqHRT8ApAEaRaH5KUHZm+CnZxOE5s1eGZiNN1cs=; b=Q0C12ZNOKNpeFgOeMyrdEc71ooy+rXUxtami5Yx+kS7lz15feb9hSY1eUUmt8Epgtd dDyON1wGjQjMCx6D5y//LxfPoHMScE6JovpW6kFodSG40JQmQq2NG576Pt7fGSO+JMdj EglXTu3jdTC/0jnZdmrjNI0HJSsw1J/UMd69rj6GwsmPJRH25Uwsz6JzCuSKYo3ZCTdF xheG9DuEFjvhu+8fmMxwa8XtalVzk90jzJyEQH+dh6dCRxDYc9becG61/zBqHDLDw1XE FDr4p1hj577tQyX/toH0c68z3l8YV48tTgeS1A/aAIMHBh539ss59zPiCcFfkAqUKNuD S6cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rVQNxqHRT8ApAEaRaH5KUHZm+CnZxOE5s1eGZiNN1cs=; b=nk9Tyjcq3wacsiAVS9FNTzo1KaL9Zrbpa58ii7jBWvLGsh7xc5ln4mrQozOzEBhqvW /wLA3mLzIGXlUH03sTpaP6xSMxY+ZN6sDFtdWUgdVLGo1OF6LKoWLU5T1w5zMZqvBr4s RVHZFSF26TQ2HwBKd0O/LWm5S9oKtRZJYJV5VJho/WgtTAuiEYSyPze5qLIUxkxGSSHq J7q40mJX8ahHBbS+Lx64Ro1hWajle0foFJGChaxJAy0us59Giyw51M1Cq6EN7Kh9So2d M8WFGnqDPqyyWXIej4a2dktkQfh2sgtRLO5MOjfc+RoxuXGGCBJ5QhGIGMTB/5y95Oc7 0lkQ== X-Gm-Message-State: AFqh2koUB7VAp4KaGnwn8svMq1vZDFz6Au6Q8LH2XxZVBJYJtRxY5YLo ctPCYkzaCVH9lLnhcNmZDES7CA== X-Google-Smtp-Source: AMrXdXtwvrksFXeMzw/YsN+zzyH0BN+q0EJoBUikocYE9MZ9Scgj71xld5ydSj+I/qQsVUgo5IsHSQ== X-Received: by 2002:a6b:fb03:0:b0:704:946f:997d with SMTP id h3-20020a6bfb03000000b00704946f997dmr26951519iog.18.1674832414147; Fri, 27 Jan 2023 07:13:34 -0800 (PST) Received: from murgatroyd (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id d3-20020a028583000000b003a7c47efde0sm1582659jai.11.2023.01.27.07.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 07:13:33 -0800 (PST) From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH] Increase size of main_type::nfields References: <20230111204418.376620-1-tromey@adacore.com> <061d47f1-fbe7-4d2f-6919-811061d0be9b@simark.ca> X-Attribution: Tom Date: Fri, 27 Jan 2023 08:13:33 -0700 In-Reply-To: <061d47f1-fbe7-4d2f-6919-811061d0be9b@simark.ca> (Simon Marchi via Gdb-patches's message of "Wed, 11 Jan 2023 16:02:55 -0500") Message-ID: <878rhoqaci.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> We could make a test case that generates a source file on the fly in Simon> standard_output_directory and compiles it. ... >> - short nfields; >> + int m_nfields; Simon> Should it be unsigned? I don't recall this field needing to be Simon> negative. I sent v2 with these changes. Tom