From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 3B8AE3889E23 for ; Wed, 9 Nov 2022 17:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B8AE3889E23 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id DD1A11003F0BC for ; Wed, 9 Nov 2022 17:11:44 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id soc4oB4NSIyPJsoc4oLlnV; Wed, 09 Nov 2022 17:11:44 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Kb0XDSUD c=1 sm=1 tr=0 ts=636bdf50 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=jHUdI9B3cMeNCT7Ht5QA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zYXf45A/4SWK2qHH42nBm40BWhS84lfobyIv4iHiCuE=; b=oW9mqZKWhQ9qR4tFzysS2z6lSb qdSDggrGw+GYnrGuHcYReF6sVtdIp/X38jpBBuWSc/xujSKUQ79e64K4jAopexxVxyko9qYvp0rNc S0/gqkfKBf0Ltn26yB0OJBMt8; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56806 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1osoc4-003OE3-Aa; Wed, 09 Nov 2022 10:11:44 -0700 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH 2/2] gdb/c++: Detect ambiguous variables in imported namespaces References: <20221026155053.3394792-1-blarsen@redhat.com> <20221026155053.3394792-3-blarsen@redhat.com> X-Attribution: Tom Date: Wed, 09 Nov 2022 10:11:42 -0700 In-Reply-To: <20221026155053.3394792-3-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Wed, 26 Oct 2022 17:50:54 +0200") Message-ID: <878rkk2gtt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1osoc4-003OE3-Aa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56806 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> This commit makes it so instead of exiting early when finding any symbol Bruno> with the correct name, GDB continues searching through include Bruno> directives until it finds another symbol with the same name but a Bruno> different mangled name - returning an ambiguous variable - or goes Bruno> through all imported namespaces and returns zero or one matching symbols. Thanks. This idea makes sense to me. Bruno> + const char* sym_name = nullptr; Wrong "*" placement. Bruno> + if(sym_name == nullptr) Missing space. Bruno> + { Bruno> + saved_sym = sym; Bruno> + sym_name = saved_sym.symbol->m_name; Bruno> + sym = {}; Bruno> + } Bruno> + else if (strcmp(sym_name, sym.symbol->m_name) != 0) Here too. There is at least one more of these as well. Bruno> + error (_("reference to \"%s\" is ambiguous"), name); It would be more friendly to users if it printed the full names of the ambiguous symbols... is that possible? Tom