From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 3D7A13858402 for ; Mon, 7 Nov 2022 15:51:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D7A13858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7FkKOL019416; Mon, 7 Nov 2022 15:51:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=seFyk04gtBRX0HRJzz9vxj+oGcxviMFEW/BnomLkysQ=; b=quMYatCoARK+yjn6NOpCItEy1dk2SoEQbzog+Vs6gWCMTeMF1RameYrWgi3hykVdzXZd lMHA/mYXWmXnF2XFYH5h8aXTz6ORurVIzR7nOisJSkskz3WYw8CCLBYgyoZ6HaBZUlgV o1aOtt+jT3rzeieCD8w4H1wntpCJDalWXGB4tEu6PI6KGUfOBh1kz9FQDFBSpQ/AyQ8X T9+ojH/6uo5q1FX/bTOZYRNRX0mAzum+qMp6GqC0oGBCxB58FaTNVka1kSs7pW3JuYjD O7uQovIF0Ef01RdPMKWNPaVBVqXlhHYp1MMCiOetGAqI+0Pw9oiMrttKiGgqUut8CS4j Wg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kngrem8qp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 15:51:55 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A7EhhdB014316; Mon, 7 Nov 2022 15:51:54 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kpcq0wmw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Nov 2022 15:51:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9ynyv3AIf8flajYgMgzjpkZntjVyD3f1I7VyJX/8BxCtUNXjaBGBhxwbNdYcutjy2xodNjxkQjrZlB10L0o7WNvG/YlY0n2oVtwzNvnK/Ye4LK6jSzf3uNWGJxPKbl5flrxyzNgGZk+oTUzIMbSK4MUuNcJCefr/PymKxHK4BN9RxCmrzVIB0QU0j5zBt3W+C3J7iefpY5eRjZqdcippscyDcAmQK6l/q3kCiNMIZNl/Vv28dqM8HUU679jMaMWkZeVtRF1F7V10KV5u2u/9I0w+s+lyymagpPbQuzaEBbGZVixTKkka8ZhqgJlrbg8A5+jRxbFDLK+ZTO+pTIarQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=seFyk04gtBRX0HRJzz9vxj+oGcxviMFEW/BnomLkysQ=; b=MW4Tv8SJa5W7J7wiXX6UDtoWas6vFTlRaX7ht4aoXGsu6u+fYl8sooiskJhc/s0/gGo4d/NEZKvNODcDhBpt65oGZSGcWptZiFcc/l0RqyH3QphWzpeAjSgQJH3JpyaybPuzI/15IKn15uhOnByvbHYw6oK1Oyijx3qUFRbKU+/2vKAQS5xFNOsLd4yyJd0Z7HrrxUR2qIyrILuqX5zNSI9870z8FkBw4TBVTiOVAr8s3Mkn+5+LI7WjMt6P5AsVZFp8/Vsy6+PsRibLTyzwSjb0gSYGAk96trG94ukvONpa4mIi4+TeHQTFEeNJ8eACak/FL31gzheoTC92+B0yIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=seFyk04gtBRX0HRJzz9vxj+oGcxviMFEW/BnomLkysQ=; b=a3lzIpbabjva6jLgC/fLmS/gQoQEKUan2pIIOvBeJleKAZkaj7JMceANmEUw87d1NmAJH0dsmVLbEfjSKTxEs6S7WT3cV4ThM60Qn4dLi2W/pM/eLLVwl9j4j9NhhUJwXKf0wDpbgOpVCV1Gv7ZONUwaL48DiQ1g9hCMF7nvjXA= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by SJ0PR10MB4509.namprd10.prod.outlook.com (2603:10b6:a03:2d9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 15:51:52 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049%5]) with mapi id 15.20.5791.026; Mon, 7 Nov 2022 15:51:52 +0000 From: "Jose E. Marchesi" To: Simon Marchi Cc: gdb-patches@sourceware.org, indu.bhagat@oracle.com, elena.zannoni@oracle.com Subject: Re: [PATCH V3] gdb: link executables with libtool References: <20221106131041.1221924-1-jose.marchesi@oracle.com> <87leomam28.fsf@oracle.com> <3b0740f3-7d92-b294-94dc-c5bed5c9b82b@simark.ca> Date: Mon, 07 Nov 2022 16:55:38 +0100 In-Reply-To: <3b0740f3-7d92-b294-94dc-c5bed5c9b82b@simark.ca> (Simon Marchi's message of "Mon, 7 Nov 2022 09:23:05 -0500") Message-ID: <878rkm92th.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0340.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::16) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|SJ0PR10MB4509:EE_ X-MS-Office365-Filtering-Correlation-Id: b0c03a7b-52cf-44df-a401-08dac0d7fcf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ntP1IyPYHLXw8Yyjqz7ROBSZA6yO5kkqtkgnPB07dERpZ4gh1aovEaoPD2Egrk2WAHBB3AsWA+7lOokcPr9we4TIUEd+U41wrt0FYK4TnNkuBAARko+zNoO8KkNlffZ6lELF7UQ9+t4GOB5/MBrpbRG/O761PaSA6so6XVXmtjikeemdULQHc1BKgv0n+VsyfhB+AzOrkJrDxGtr0Q/BOExe55jQ13b/IAHFFoUjK0pywmL2D3oiIycH5Z4p1H2RwbeYUH+6eS42w7btCVkCZKbWvvGGVMRo3winSCggxFVbO9snwhGJwSyqmUbN8XjcQGBiRXgT2QvY/iT+afNNl7zuZTf8cEiXsvrsfBJskTkO0l58I+QOLTJ34eXmZCKc9VKT2cVsKdpIzZ1grD6Z6SzTxHYYGUG5WcLotrVhM61RHU5fVM+XMJ/jVp01arNtPires2KEr+6jdxfyiqjPmhkgY4AtcFkpRXqEOfe6lmrfo1DCeldrGI45YqAFoo9U/c3VO8Tob/emodg5d93gOzOGvzj/8DfoUDPt22dya8Y80ToJcVOx6X2rqrIPAT0IaYXEoB26CLACcYbjPpFvtDcRemZGfw2P+mSaTMLi3zyq6qEFSMklpzPX0Yg9lGiKe00JCF187BAn88NzNKqFdI2k4mZTmlaQCUPsvzC2XHAyfIli/lsjos3xQI9u+2xksh9K4cPJ/TRXJLhCx7Ot9afK0yP7wRhQ+0zoztWvgdSF4FjDqek4j7IMZ8WfNUULxxCAeI5HTpVDjFrehrCNEcSgETG8n/bpZ+1eICby9qv3wCItf2ibNx4MJ+DZl+FSF9nihJx5dIu46zmaT7MtCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(136003)(396003)(376002)(366004)(451199015)(36756003)(84970400001)(86362001)(2906002)(107886003)(6666004)(6506007)(186003)(6512007)(26005)(53546011)(83380400001)(2616005)(66476007)(66556008)(4326008)(66946007)(8676002)(478600001)(6916009)(8936002)(316002)(6486002)(966005)(5660300002)(41300700001)(38100700002)(460985005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TpHVbDDnZm8qnVm3FAbKq2rrhClLVUNwxuqipWm6zkAGrWDhyjsBqfLk/B/H?= =?us-ascii?Q?JAPi02n0MRIcfW2AAUP71fcHNf73kYfepnk4B9lK8p9X3SCh2XvpdumCax1R?= =?us-ascii?Q?1o2ig5+Nif7p6w9QK6S3t6o2A0gbRyE2NItbX59nEuP37ruSYt1cjMwkTkTz?= =?us-ascii?Q?8Vb3p7fx1GecKzokKxbXrRXTCSSgnu+S/M5NHCPuFr1vR/ngVxeUYduUTmL6?= =?us-ascii?Q?lr0ctI1qnbk0Ex5RA85SJolK3+tMqeCrgV+xkcyatRW5VC1fB2y0f3F5JW1S?= =?us-ascii?Q?MsOCzFfZ4vH3yfUkX4BcZSae5G+GuPGTOPKq+6l5AIHHPCt488rK9JD8/V5+?= =?us-ascii?Q?WJL894p2dRYoD8o/2Dt0pAXDRFMlBIubGZ7PaQS5+ULuwT+YmmJj6IR1nBJ5?= =?us-ascii?Q?6EyDVo6wUNkVcxwwtc3d9xXLVnZAB3RDtA7JfeOpW/xHyI9moZtGt95QmJjC?= =?us-ascii?Q?J68g3w2JhhnjmJlZLX+mzraJD12pJSNJNBnW+eAF2In08Kv/r/iXUhdtC9zL?= =?us-ascii?Q?Y75TzVFnrFGSt7qTs69KEVjNChzjodeEhfruwFrRa1omdKzbREWqseAwrY8d?= =?us-ascii?Q?HL/4G3StIwGRIHL3RO8eEeTTgGn9mIqxONFElr5PRETaI516ppNqXnGPsZN6?= =?us-ascii?Q?Q27qZvNhwHhxcEh3FQ85Bs1ybj8ipbenS12Gxh2twdf/kw4DVszaBUneE8ij?= =?us-ascii?Q?swOd5hmsAf7th83B1lW2Hm7YnhRMkncXHKVmKlhCxhxWcJNyxuF+R+myXPqi?= =?us-ascii?Q?xqibQU1dJvpqLKZjw+QsCbORZNpGHMVOR8p9wl80Wk4o8GGQX8spBqvOEe3X?= =?us-ascii?Q?C7+DMj7fJcQUucfEduaCRcb3BKCaDNgBDDJCxjb97aNSAi00f6sYWZIY4z0C?= =?us-ascii?Q?UPyD9JbbC5fAyMRE5+5i+s+NcwtDCFdoXJquGPv82G3+ZZx9QvOulsEwwgly?= =?us-ascii?Q?+0in8r6L16t5VV1i39NNj8z6keUWXfJURyCorGWpKZq5ymrFxKXW7xuzFJIA?= =?us-ascii?Q?KaSpXiwUubQVfaHQ3rqCSNUBJhUSQ4cqF/SOQ9cZNdGUBOrjozK3oRsraU3P?= =?us-ascii?Q?A88gVMlIonwB58fRpVBVsVVOzZopIJJ+iXSWEQqD2IG9uHS80IK+STlHXvLd?= =?us-ascii?Q?lTjmK7/OoSuMKQtVMJ1suJ9EjtledZsXB9QSls9JSs/R69UDZGe3rFiQfgrL?= =?us-ascii?Q?Ty0SYrPK0mIwnBdZPI7nwxRmeAW9PoaLM53TDcmZZtNPB4UrJLs1R3XAjwqQ?= =?us-ascii?Q?/EQpNaOwVZ3nfQBsK22+zSRND/ShdPvNuAPj88gmmEHf/gD0N2hkgVlc9DK4?= =?us-ascii?Q?4svN6DnEIyr2hFtprLpvhgt+oOnv6b480kiP0OcgpxwqXb76pgkDWlAIoCtS?= =?us-ascii?Q?KobQsp8KQ3HGR5OsxeTAI2EhRg24Lfa1oVPKS6BKo+LbcLWfE51FD5qqFZCF?= =?us-ascii?Q?w44P/WAKfCJ06csiY0zBd6m1GB6N724cVKEucARIixKt4rSxarZFEsR/wlRC?= =?us-ascii?Q?Hs+EWMgefLLRmFQwvrwNcBezOY2XInJmHLL8Kt9+FElTloHbuLvOfMnDIFuW?= =?us-ascii?Q?LLMYHvgElwDECwEjJJepnjfaAjvEfKKwyqyS9FeFGJAPwEp2o7K0oc7i0pt3?= =?us-ascii?Q?Ag=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0c03a7b-52cf-44df-a401-08dac0d7fcf5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 15:51:52.3929 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rEVcMI2pSOzt8ESr7sGdxKxxuY1PwZ/hCIKAso9eeZoeM5DMdL4ri9HmbxlLVrIsrwFv68inY7rBAhL2zcdJoHSwdiCQ89wCNBM85J0q918= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4509 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-07_08,2022-11-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211070127 X-Proofpoint-ORIG-GUID: C9CP3V4lxQRCoLy2sgdfkyW9m39ctB2N X-Proofpoint-GUID: C9CP3V4lxQRCoLy2sgdfkyW9m39ctB2N X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 11/7/22 09:14, Jose E. Marchesi wrote: >> >>> On 11/6/22 08:10, Jose E. Marchesi via Gdb-patches wrote: >>>> [Changes from V2: >>>> - Add .. to AC_CONFIG_MACRO_DIRS so autoreconf DTRT. >>>> - Refer to libopcode as a libtool library. >>>> - Do not use libtool --mode=execute in testsuite/lib/gdb.exp. >>>> - Remove spurious entry from top-level ChangeLog. >>>> - Remove ChangeLog fragment from commit message. >>>> - Add git trailer to commit message. >>>> - Typos fixed in commit message.] >>>> >>>> This patch changes the GDB build system in order to use libtool to >>>> link the several built executables. This makes it possible to refer >>>> to libtool libraries (.la files) in CLIBS. >>>> >>>> As an application of the above, >>>> >>>> BFD now refers to ../libbfd/libbfd.la >>>> OPCODES now refers to ../opcodes/libopcodes.la >>>> LIBBACKTRACE_LIB now refers to ../libbacktrace/libbacktrace.la >>>> LIBCTF now refers to ../libctf/libctf.la >>>> >>>> NOTE1: The addition of libtool adds a few new configure-time options >>>> to GDB. Among these, --enable-shared and --disable-shared, which were >>>> previously ignored. Now GDB shall honor these options when linking, >>>> picking up the right version of the referred libtool libraries >>>> automagically. >>>> >>>> NOTE2: I have not tested the insight build. >>>> >>>> NOTE3: For regenerating configure I used an environment with Autoconf >>>> 2.69 and Automake 1.15.1. This should match the previously >>>> used version as announced in the configure script. >>>> >>>> NOTE4: Now the installed shared object libbfd.so is used by gdb >>>> if binutils is installed with --enable-shared. >>>> >>>> Testing performed: >>>> >>>> - --enable-shared and --disable-shared (the default in binutils) work >>>> as expected: the linked executables link with the archive or shared >>>> libraries transparently. >>>> >>>> - Makefile.in modified for EXEEXT = .exe. It installs the binaries >>>> just fine. The installed gdb.exe runs fine. >>>> >>>> - Native build regtested in x86_64. The installed gdb runs fine. >>>> >>>> In the regression testing I'm observing that the following tests >>>> doesn't seem to be deterministic: >>>> >>>> gdb.base/step-over-syscall.exp >>>> gdb.threads/process-dies-while-detaching.exp >>>> gdb.threads/process-dies-while-handling-bp.exp >>>> >>>> Sometimes some of the the tests in these files unexpectedly fail, >>>> like in: >>>> >>>> -PASS: gdb.threads/process-dies-while-detaching.exp: single-process: \ >>>> continue: detach: continue >>>> +FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: \ >>>> continue: detach: continue >>>> >>>> Sometimes they unexpectedly pass: >>>> >>>> -KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: \ >>>> check_pc_after_cross_syscall: single step over clone \ >>>> final pc (PRMS: gdb/19675) >>>> +PASS: gdb.base/step-over-syscall.exp: clone: displaced=on: \ >>>> check_pc_after_cross_syscall: single step over clone final pc >>>> >>>> -KFAIL: gdb.threads/process-dies-while-handling-bp.exp: \ >>>> non_stop=on: cond_bp_target=0: inferior 1 exited \ >>>> (prompt) (PRMS: gdb/18749) >>>> +PASS: gdb.threads/process-dies-while-handling-bp.exp: \ >>>> non_stop=on: cond_bp_target=0: inferior 1 exited >>>> >>>> - Cross build for aarch64-linux-gnu built to exercise >>>> program_transform_name and friends. The installed >>>> aarch64-linux-gnu-gdb runs fine. >>>> >>>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29372 >>>> --- >>>> gdb/Makefile.in | 14 +- >>>> gdb/aclocal.m4 | 5 + >>>> gdb/config.in | 4 + >>>> gdb/configure | 31544 ++++++++++++++++++++++++++++++--------------- >>>> gdb/configure.ac | 17 +- >>> >>> This diffstat claims there are changes to configure, but the patch >>> doesn't actually has them. Perhaps it's on purpose, because they are a >>> bit on the big side to send by email. I'd just like to double-check >>> that when I run autoreconf on my side, I get the same result as you. >>> Could you perhaps upload your patch to a git branch? It could be a user >>> branch here in the sourceware binutils-gdb repo. >> >> Yeah I removed the configure thunk because it is big. >> Just pushed the stuff to a branch users/jemarch/gdb-libtool. > > Thanks, this works for me, I think you can go ahead and push this. > Please add the following trailer to the commit: > > Approved-By: Simon Marchi Branch rebased to latest master, trailer expanded with the Approved-By and, sanity-checked and pushed to master. I will be on the look for possible breakages. Thanks!