From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EBACF3856DC2 for ; Wed, 26 Oct 2022 12:37:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBACF3856DC2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666787834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xWuPTX0uynEkE0n/HcfuwqAfP/6I5NzQ6bjbPXxO8L0=; b=PlAN9XTdEiPkhSMxFKlrItzEwOr7CV+IEQaxrE+UwDBfYSToR36Hu1G+rlhE3ERBI7hLKT C+N62PdfcBFxjk9qsUW5UjHvqfQFFElWa8WGyXlxWoTp7rjU1xJWpwO5/JYiRKQlSHLim9 TYl6QRIRKq2Y4YvYjyTJBBvhx40sOYk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-392-JmE1gnO9MPidXDojIy9P3A-1; Wed, 26 Oct 2022 08:37:11 -0400 X-MC-Unique: JmE1gnO9MPidXDojIy9P3A-1 Received: by mail-wm1-f71.google.com with SMTP id r18-20020a05600c35d200b003cb2ba79692so3916648wmq.5 for ; Wed, 26 Oct 2022 05:37:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xWuPTX0uynEkE0n/HcfuwqAfP/6I5NzQ6bjbPXxO8L0=; b=mo8XHxrIz4Wv4JUoljj+ajNQzgkZgwMZzBHDHrcvIfStg7kUkGz51SOpVCT78vUz+/ 5JFpdcw3qR2v7YlzimTsL4vrg/MluIuY2LNhlyuikZ2bZXbeexL+nVknsq1AVJ06nGYb xVphvj7gIc10swykz9UwjJ3b5sD4Kk56Lj1Uy/tkEZNETetzuwbo/fguWX+5XWW9gqWI VtMis5C8K/hsiw5lgy+VIjdaOu3RfKHsTtbs6Hz7MQJ4SYnh3VFKuHisW6J3BAKNDru+ 9tDSn4Z5gZpusKEk7fF6lMXqghbQRGy+8RFH8DHLW7u4YHG6981rz5VYSG2f9MSJaCKU s6Qw== X-Gm-Message-State: ACrzQf3rCZ/U8AR4MnNAUZY90JmczZ0C2G/jSN3cGCbdOENtM0pYV0W7 1iaW5t9DAxOiICQsb1LLZiDEgAJ+ogKlCO2pa1RAMrjoJ/LhyKE9Z3X0fZeqLiPIhBMCtKSuP9W DEcYnysIlybh6G7P4eSXPiA== X-Received: by 2002:a5d:6701:0:b0:22e:6545:995d with SMTP id o1-20020a5d6701000000b0022e6545995dmr29006935wru.301.1666787830190; Wed, 26 Oct 2022 05:37:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/TLmGa4LAtMMsFkc48hbIV6JlpaVvE2PPEwq96nhxllHGnsM+lzlf/TjxqyNOGQmwmWM1jA== X-Received: by 2002:a5d:6701:0:b0:22e:6545:995d with SMTP id o1-20020a5d6701000000b0022e6545995dmr29006926wru.301.1666787830007; Wed, 26 Oct 2022 05:37:10 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c4e8c00b003c6c1686b10sm2102768wmq.7.2022.10.26.05.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 05:37:09 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH 04/11] gdb/testsuite: add XFAIL to gdb.cp/derivation.exp when using clang In-Reply-To: <20221004170747.154307-6-blarsen@redhat.com> References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-6-blarsen@redhat.com> Date: Wed, 26 Oct 2022 13:37:08 +0100 Message-ID: <878rl27ocr.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno Larsen via Gdb-patches writes: > When running gdb.cp/derivation.exp using clang, we get an unexpected > failure when printing the type of a class with an internal typedef. This > happens because clang doesn't add accessibility information for typedefs > inside classes (see https://github.com/llvm/llvm-project/issues/57608 > for more info). To help with clang testing, an XFAIL was added to this > test. > --- > gdb/testsuite/gdb.cp/derivation.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/gdb.cp/derivation.exp b/gdb/testsuite/gdb.cp/derivation.exp > index c95fef004b5..2283e5b3616 100644 > --- a/gdb/testsuite/gdb.cp/derivation.exp > +++ b/gdb/testsuite/gdb.cp/derivation.exp > @@ -77,6 +77,10 @@ gdb_test "up" ".*main.*" "up from marker1" > > gdb_test "print a_instance" "\\$\[0-9\]+ = \{a = 1, aa = 2\}" "print value of a_instance" > > +# clang does not add accessibility information for typedefs inside classes Missing full-stop at the end of the sentence. > +if {[test_compiler_info {clang*}]} { > + setup_xfail "clang 57608" *-*-* > +} Add language to test_compiler_info call. Thanks, Andrew > cp_test_ptype_class \ > "a_instance" "" "class" "A" \ > { > -- > 2.37.3