From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CE71E3858421 for ; Mon, 24 Oct 2022 11:20:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE71E3858421 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666610428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dO4vYqECvIsAg5BXTnbPF7MQKi8pRi2lyr+5gdOTAMs=; b=fXx/i/8Q7QpX234F8wA//0XwvoLlm4Y9RjYWpLtZOsqjsV6a+g8AKdQOchfkNC5mLCn6oI NJPUC7e5vm9M7jVTSpWfGT32aWSUdmBWHs9rM91CY/Vd6Couh6TdyrdMLqV9NdQRAvdM8u qRRUY8AtzyHLc43YQ3kGJFqvNveHjQw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-487-qrjD2t1lOZewTHPE0bCG2w-1; Mon, 24 Oct 2022 07:20:27 -0400 X-MC-Unique: qrjD2t1lOZewTHPE0bCG2w-1 Received: by mail-qt1-f198.google.com with SMTP id k9-20020ac85fc9000000b00399e6517f9fso6823868qta.18 for ; Mon, 24 Oct 2022 04:20:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dO4vYqECvIsAg5BXTnbPF7MQKi8pRi2lyr+5gdOTAMs=; b=FCM78LLFb9PUtkGuTXOFXZhBh71OgJaajTi2TU8FUMD1WecTHBTM6keoxWJnLDAavl suYcSc34XGadTJCZ+L8LqoqJUm9uuTop96JzIiyTHZoUNIwLON8FAUp6qIlvnC0/QsNP acoWzANykB9PtYwCUN3FZB4QcACo5Q3ES2RgTrdDf6FxbTwjzsj942DWndUYwqGOjbxW NaNia3p3Yte0uf9hfHvkn5dWML5+lkyyM/IYqPhFgdJXJJyKOMlquKSpNyFewm28zBZA 5qWM+48NQqM0PKA1OP34Lt7LcAE0Zo+K6qDc2DGV4j62PdlW8IxOyUzlai8R6VOeF53S QNZA== X-Gm-Message-State: ACrzQf2vX2QFDwYPam9nPkY0jsEoXnKfOKeHKoRs+TDz60B2HMrJaxzZ hw4D9BCKSI4jW/URNskuMX+8vafz48ewFa892lETsh3574cOM3X//bKYU0+lUyABjGq7vX0dltX VZplYWVGgWwqmiobqHSRNfA== X-Received: by 2002:a05:6214:528b:b0:4b1:d4f4:3c46 with SMTP id kj11-20020a056214528b00b004b1d4f43c46mr26818497qvb.131.1666610426457; Mon, 24 Oct 2022 04:20:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5nW7NEj3oBC327YisUCofpS/0wZqfIC4//5P7vRJugg2lm/JGU0oT4BKlEribiVXYQsiJtYw== X-Received: by 2002:a05:6214:528b:b0:4b1:d4f4:3c46 with SMTP id kj11-20020a056214528b00b004b1d4f43c46mr26818485qvb.131.1666610426267; Mon, 24 Oct 2022 04:20:26 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id h5-20020a05620a284500b006f16148fa96sm4547154qkp.91.2022.10.24.04.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 04:20:25 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] [gdb] Fix rethrow exception slicing In-Reply-To: <20221024084913.19429-1-tdevries@suse.de> References: <20221024084913.19429-1-tdevries@suse.de> Date: Mon, 24 Oct 2022 12:20:24 +0100 Message-ID: <878rl5a2o7.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries via Gdb-patches writes: > While investigating PR29712, I used my ignore-errors patch ( > https://sourceware.org/pipermail/gdb-patches/2021-May/178990.html ) and > found that the thrown error was not caught by ignore-errors due to object > slicing of the exception by a rethrow. > > In other words, a gdb_exception_error is thrown, caught and rethrown, but the > rethrow throws a gdb_exception instead, which will not be caught by an > encapsulating catch gdb_exception_error. > > Fix this and one more occurrence of rethrow exception slicing that I found > using grepping. Both of these look good for me. Thanks, Andrew > > Tom de Vries (2): > [gdb] Fix rethrow exception slicing in pretty_print_insn > [gdb] Fix rethrow exception slicing in insert_bp_location > > gdb/breakpoint.c | 28 +++++++++++++++++++++------- > gdb/disasm.c | 4 ++-- > 2 files changed, 23 insertions(+), 9 deletions(-) > > > base-commit: b347f578952a29ff9b02090b0dafec563520c80b > -- > 2.35.3