From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8DB353858401 for ; Wed, 11 May 2022 11:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DB353858401 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-KbJlAfKFNg258GsKtdIpEg-1; Wed, 11 May 2022 07:23:30 -0400 X-MC-Unique: KbJlAfKFNg258GsKtdIpEg-1 Received: by mail-wr1-f71.google.com with SMTP id p10-20020adfaa0a000000b0020c4829af5fso715559wrd.16 for ; Wed, 11 May 2022 04:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=fweshc0X4GvEeEhArAS5np69JOeOs+OKwJSPzJVzwEs=; b=APJsTRecY9ymiI+DnHycR/1G3GNkwvWLgjTPYDAAOFA1jNW29so9zV4P+M+46owzMJ nSz0WiKr1+UTCqHVqI6oqAAN2AUAvpPdi35IsIiDxgDsUWJbTd5srjFqD1QZ5+JRFO/B rgK7+at2vOWiB/SIvwyPPoORcXOeEzr5YAJCJnB64LrFj3AHodQjY+uU54ebAixAwDDD Ky98iK1pOiJnbKKjUN9eC/+s0fBjM0riuSBLMsrSkGkCseojxLIXUn7GYx1WzbuFya9t D+Ex23M7N22EqcKrjX/JZMTgCDprmxHoMw7jPMPvQxFjkhKxppXrYAt7u9xSyr71mtsK fW/A== X-Gm-Message-State: AOAM530IKu304pQ2xgLp+dcsdsDQ8pNQfGksVZ7uijeRVbwhX53hkkyE XURuk6DQp/htZi/a+a7j49INXBhFmvrqfz2f1hTDRam0xc2QhbXXXiI+Kjp0RNJcrlez0K/pht3 Z8nkJsAFxXHKdXwiRnu/hmQ== X-Received: by 2002:a05:600c:3d16:b0:394:4ff0:d818 with SMTP id bh22-20020a05600c3d1600b003944ff0d818mr4305761wmb.5.1652268208856; Wed, 11 May 2022 04:23:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU/tB/sUV93NAcI3YS2bkx5id7zFoQL1yySVG+WyrAG8LJci7c1p+lNJheb7ov+tRd3tJBGQ== X-Received: by 2002:a05:600c:3d16:b0:394:4ff0:d818 with SMTP id bh22-20020a05600c3d1600b003944ff0d818mr4305745wmb.5.1652268208584; Wed, 11 May 2022 04:23:28 -0700 (PDT) Received: from localhost (host81-136-113-48.range81-136.btcentralplus.com. [81.136.113.48]) by smtp.gmail.com with ESMTPSA id c13-20020adfed8d000000b0020c5253d8d7sm1484211wro.35.2022.05.11.04.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 May 2022 04:23:28 -0700 (PDT) From: Andrew Burgess To: Nils-Christian Kempke , gdb-patches@sourceware.org Cc: JiniSusan.George@amd.com Subject: Re: [PATCH 06/18] gdb/testsuite: rename intel next gen c/cpp compilers In-Reply-To: <20220510142437.1397399-7-nils-christian.kempke@intel.com> References: <20220510142437.1397399-1-nils-christian.kempke@intel.com> <20220510142437.1397399-7-nils-christian.kempke@intel.com> Date: Wed, 11 May 2022 12:23:26 +0100 Message-ID: <878rr8l3dd.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 11:23:32 -0000 Nils-Christian Kempke via Gdb-patches writes: > The name for icx and icpx in the testsuite was earlier set to 'intel-*' > by the compiler identification. This commit changes this to 'icx-*'. I think it is worth mentioning here that the intel-* pattern is not (currently) checked for in any compiler_info check. My first thought when I saw this was that you'd surely forgotten to update the patterns within the testsuite... Thanks, Andrew > --- > gdb/testsuite/lib/compiler.c | 2 +- > gdb/testsuite/lib/compiler.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/compiler.c b/gdb/testsuite/lib/compiler.c > index 451cae3831..86140f8c0e 100644 > --- a/gdb/testsuite/lib/compiler.c > +++ b/gdb/testsuite/lib/compiler.c > @@ -75,5 +75,5 @@ set total_length [string length __clang_version__] > set version_start_index [string last "(" __clang_version__] > set version_string [string range __clang_version__ $version_start_index+5 $total_length-2] > set version_updated_string [string map {. -} $version_string] > -set compiler_info "intel-$version_updated_string" > +set compiler_info "icx-$version_updated_string" > #endif > diff --git a/gdb/testsuite/lib/compiler.cc b/gdb/testsuite/lib/compiler.cc > index 1dfefee057..a52e81c2e3 100755 > --- a/gdb/testsuite/lib/compiler.cc > +++ b/gdb/testsuite/lib/compiler.cc > @@ -63,5 +63,5 @@ set total_length [string length __clang_version__] > set version_start_index [string last "(" __clang_version__] > set version_string [string range __clang_version__ $version_start_index+5 $total_length-2] > set version_updated_string [string map {. -} $version_string] > -set compiler_info "intel-$version_updated_string" > +set compiler_info "icx-$version_updated_string" > #endif > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928