From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Add accessors for symbol's artificial field
Date: Wed, 20 Apr 2022 09:20:56 -0600 [thread overview]
Message-ID: <878rrzu6g7.fsf@tromey.com> (raw)
In-Reply-To: <f04b51a3-b6ac-f747-6a26-9ae7cbba2f95@simark.ca> (Simon Marchi's message of "Wed, 20 Apr 2022 11:15:41 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> Since this is a boolean / flag, I would name those "is_artificial" and
Simon> "set_is_artificial". To follow GDB's conventions it should probably be
Simon> "artificial_p", but I always found this scheme awkward to read (vs
Simon> is_foo, which just reads like plain english).
I'll make the change.
I like the _p form for nostalgic reasons -- it's derived from Lisp, the
actually fun language -- but I tend to agree now that we should keep
things more accessible.
Tom
next prev parent reply other threads:[~2022-04-20 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:50 [PATCH 0/6] More symbol methods Tom Tromey
2022-04-20 14:50 ` [PATCH 1/6] Add accessors for symbol's artificial field Tom Tromey
2022-04-20 15:15 ` Simon Marchi
2022-04-20 15:20 ` Tom Tromey [this message]
2022-04-20 14:50 ` [PATCH 2/6] Use array_view for symbol_impls Tom Tromey
2022-04-20 14:50 ` [PATCH 3/6] Remove symbol::aclass_index Tom Tromey
2022-04-20 14:50 ` [PATCH 4/6] Replace symbol_objfile with symbol::objfile Tom Tromey
2022-04-20 14:50 ` [PATCH 5/6] Replace symbol_arch with symbol::arch Tom Tromey
2022-04-20 14:50 ` [PATCH 6/6] Replace symbol_symtab with symbol::symtab Tom Tromey
2022-04-20 15:20 ` Simon Marchi
2022-04-20 15:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rrzu6g7.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).