From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 8B00E385E45C for ; Mon, 28 Mar 2022 19:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B00E385E45C Received: by mail-il1-x130.google.com with SMTP id u13so1870499ilv.6 for ; Mon, 28 Mar 2022 12:54:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=MKjxNxKm8IY0Cx0C42jrPFxDkrMT0Mc32e1750/cg7s=; b=X1vRqlIMvY0ZV4WW6MGlFbziYhBGwDKp2hiOp1G3yx45E4eozHfkUa2UEVQcSIE3f+ pSm9tt/AEyBFIyfGXfDZM9Eheg9WpGE8gn6oxElhAF+PsKsYu2sRnTof02aopDTskImk BxH/wYt3tIj7mZj44W/fYilfqGfoZm31DATHYQ52KjzFXPRcxcMTTZRorQG1vJMar6ss 9mZGYM02d32A+eHIX2OaNqbQpbe/wfQ6FMLd2XyRCUyBd0oGJHfEJX0zUvkEHPfayRzv hJB1Y6UhnGfC4mYDEnBDFjY+9pv0SRI4bQ+8oR4SOAnE/ZWBu0DoYmjyVVPmt2n0oDgK O23Q== X-Gm-Message-State: AOAM532zXjVKlN0kwVthwyUPNMaWqcINaulqaV6zuHvnrUqxKs14IACe MxmP6R1bx436oxogSQ+mSY7aEA== X-Google-Smtp-Source: ABdhPJxhWp2p/6BqFHlxD45BHKthJCx1wD8ky8O6noch2uGRb1+5twjURCOdbCO3VF4EzlE7Z4TLoA== X-Received: by 2002:a05:6e02:964:b0:2c8:50c6:b2b1 with SMTP id q4-20020a056e02096400b002c850c6b2b1mr6756886ilt.216.1648497283474; Mon, 28 Mar 2022 12:54:43 -0700 (PDT) Received: from murgatroyd (71-211-175-224.hlrn.qwest.net. [71.211.175.224]) by smtp.gmail.com with ESMTPSA id d8-20020a056e02214800b002c7bea34e3dsm7827871ilv.46.2022.03.28.12.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 12:54:43 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH 0/6] Handle split functions in call site chains References: <20211201220432.4105152-1-tromey@adacore.com> <87tucilu0x.fsf@tromey.com> X-Attribution: Tom Date: Mon, 28 Mar 2022 13:54:42 -0600 In-Reply-To: <87tucilu0x.fsf@tromey.com> (Tom Tromey via Gdb-patches's message of "Mon, 28 Feb 2022 11:34:38 -0700") Message-ID: <878rst26pp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 19:54:45 -0000 Tom> This series fixes a bug in DW_OP_entry_value handling. Tom> A large customer program that is compiled with optimization has a Tom> function that is split into hot and cold parts. The DWARF uses Tom> DW_AT_ranges to represent this. Tom> [...] Tom> Patch #4 could use an extra examination, both because I convert Tom> explicit state management to recursion (IMO ok because these call Tom> chains tend to be short); but also because I think I found a bug in Tom> the current code. > I think at this point I will delay this until after the 12.1 branch is > made. Then I will probably check it in. I'm checking this in now. I've rebased it, which only required minor changes. I've also regression tested it on x86-64 Fedora 34. Tom