From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/8] gdb: make add_setshow commands return set_show_commands
Date: Mon, 24 May 2021 08:57:17 -0600 [thread overview]
Message-ID: <878s44xjqq.fsf@tromey.com> (raw)
In-Reply-To: <20210518202334.2659379-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 18 May 2021 16:23:26 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> Some add_set_show commands return a single cmd_list_element, the one for
Simon> the "set" command. A subsequent patch will need to access the show
Simon> command's cmd_list_element as well. Change these functions to return a
Simon> new structure type that holds both pointers.
Looks good.
Simon> I initially only modified add_setshow_boolean_cmd (the one I needed),
Simon> but I think it's better to change the whole chain to keep everything in
Simon> sync.
I agree. Also, I feel like I've wanted this change before, so I wonder
if there's a hack somewhere in the code to work around the lack of it.
Maybe someday we'll trip over it.
Tom
next prev parent reply other threads:[~2021-05-24 14:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:23 [PATCH 0/8] Change alias creation functions to accept target as cmd_list_element Simon Marchi
2021-05-18 20:23 ` [PATCH 1/8] gdb: make add_setshow commands return set_show_commands Simon Marchi
2021-05-24 14:57 ` Tom Tromey [this message]
2021-05-18 20:23 ` [PATCH 2/8] gdb: remove unnecessary lookup_cmd when deprecating commands Simon Marchi
2021-05-18 20:23 ` [PATCH 3/8] gdb/python: use return values of add_setshow functions in add_setshow_generic Simon Marchi
2021-05-18 20:23 ` [PATCH 4/8] gdb: make add_com_alias accept target as a cmd_list_element Simon Marchi
2021-05-18 20:23 ` [PATCH 5/8] gdb: make add_info_alias " Simon Marchi
2021-05-18 20:23 ` [PATCH 6/8] gdb: remove add_alias_cmd overload that accepts a string Simon Marchi
2021-05-18 20:23 ` [PATCH 7/8] gdb: add make-init-c script Simon Marchi
2021-05-19 15:52 ` Simon Marchi
2021-05-24 15:15 ` Tom Tromey
2021-05-25 16:38 ` Simon Marchi
2021-05-26 12:39 ` Tom Tromey
2021-05-27 18:01 ` Simon Marchi
2021-05-18 20:23 ` [PATCH 8/8] gdb: add option to reverse order of _initialize function calls Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s44xjqq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).