Re: [PATCH] [gdb.base] Enable macro test for clang compiler

[Tom Tromey <tom@tromey.com>]

>>>>> ">" == Tomar, Sourabh Singh via Gdb-patches <gdb-patches@sourceware.org> writes:

>> Requesting review on this patch, Please have a look.

Thank you.

>>  	* gdb.base/macscp.exp: Append -g3 to additional_flags for clang.
 
>> +2021-03-10  Sourabh Singh Tomar  <SourabhSingh.Tomar@amd.com>
>> +
>> +	* gdb.base/macscp.exp: Remove -g3 from additional_flags and
>> +	append -fdebug-macro to additional_flags for clang.
>> +

This diff seems a little weird - there are newer ChangeLog entries
visible.

Maybe you have other patches after this one ... that's fine, but it's
good usually to make a new branch when submitting to avoid this kind of
thing.

 
>>  get_compiler_info
>> -if { [test_compiler_info "gcc-*"] || [test_compiler_info "clang-*"] } {
>> +if { [test_compiler_info "gcc-*"] } {
>>      lappend options additional_flags=-g3
>>  }
 
>> +get_compiler_info
>> +if { [test_compiler_info "clang-*"] } {
>> +    lappend options additional_flags=-fdebug-macro
>> +}

I suspect the second call to get_compiler_info isn't needed, and this
could be phrased as "else if { ... clang ... }".

Tom