From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.109]) by sourceware.org (Postfix) with ESMTPS id 89C7F39F1480 for ; Fri, 5 Feb 2021 15:40:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89C7F39F1480 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id BAD528E5188 for ; Fri, 5 Feb 2021 09:40:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 83DYl1ibQuDoA83DYl39RP; Fri, 05 Feb 2021 09:40:20 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M4dKkIq3fzDYtpLimdY5ldCvKA0G8fAZsoM9yZkgoRQ=; b=yPZrJmmOo2MK7ByQqATu7Wfru+ 6mAlbVpFoOwS/8VbYh4+Cd2MIJ35MCX+HG49uesvvWKPUslbueSmN05FJmJv51M12MQ6rzXIUyrzV UgaiKvCiHiJ7UfCMo/gSe8NRn; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:42278 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l83DY-0038AP-Cc; Fri, 05 Feb 2021 08:40:20 -0700 From: Tom Tromey To: Weimin Pan via Gdb-patches Cc: Weimin Pan Subject: Re: [PATCH 2/5] CTF: set up debug info for function arguments References: <1612230528-25905-1-git-send-email-weimin.pan@oracle.com> <1612230528-25905-2-git-send-email-weimin.pan@oracle.com> <1612230528-25905-3-git-send-email-weimin.pan@oracle.com> X-Attribution: Tom Date: Fri, 05 Feb 2021 08:40:19 -0700 In-Reply-To: <1612230528-25905-3-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Mon, 1 Feb 2021 20:48:45 -0500") Message-ID: <878s825xr0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l83DY-0038AP-Cc X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:42278 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_RP_RNBL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 15:40:39 -0000 >>>>> ">" == Weimin Pan via Gdb-patches writes: >> Added this support in read_func_kind_type after gcc started generating >> CTF for function arguments. >> Expanded gdb.base/ctf-ptype.exp to test function arguments. Also fixed >> some typos. Thank you. This needs ChangeLog entries. >> --- >> gdb/ctfread.c | 34 +++++++++++++++++++++++++++++++++- >> gdb/testsuite/gdb.base/ctf-ptype.exp | 19 ++++++++++++++++--- I guess the two existing ctf tests could also be moved to the proposed gdb.ctf. What do you think? If you agree, this would make sense to do as a separate "FYI" patch. >> + /* Set up function's arguments. */ >> + argc = cfi.ctc_argc; >> + type->set_num_fields (argc); >> + if (cfi.ctc_flags & CTF_FUNC_VARARG) >> + type->set_has_varargs (1); Should be 'true' instead of '1'. >> + argv = XNEWVEC (ctf_id_t, argc); gdb style is to use a std::vector for this kind of thing now. That way you can remove the explicit memory management. Tom