From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.43]) by sourceware.org (Postfix) with ESMTPS id ECB96388A024 for ; Thu, 2 Apr 2020 19:01:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ECB96388A024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id C68A8E719A for ; Thu, 2 Apr 2020 14:01:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id K56CjIp3MSl8qK56CjoML7; Thu, 02 Apr 2020 14:01:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vnZR+Ix91ryrKOFde+4iqKW4g4ag1a7kkmK6zJaVXik=; b=WlTtPud5DQNU20dEzMidwujvj/ 5cblIHfTS4GmkonDP8/k6UAxAh5xHeigFFlxyUWA4+S8/RMbcGNIWSA7Pzn1M0pjEAiru7kPN58pN 87GMmbOIehFdPoP8cbpEC5QCD; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:40470 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jK56C-001NMG-90; Thu, 02 Apr 2020 13:01:56 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Pedro Alves via Gdb-patches , Pedro Alves , Simon Marchi , Jon Turney Subject: Re: [PATCH] gdb: use bfd_get_section_contents to read section contents in, is_linked_with_cygwin_dll References: <20200316170845.184386-1-simon.marchi@polymtl.ca> <20200316170845.184386-7-simon.marchi@polymtl.ca> <0b76517a-f6dd-0aa8-17fb-ce5a9accbf42@redhat.com> <87ftdmvx85.fsf@tromey.com> <6b6b7467-2db4-56c9-dd98-3082b7b68abe@polymtl.ca> X-Attribution: Tom Date: Thu, 02 Apr 2020 13:01:55 -0600 In-Reply-To: <6b6b7467-2db4-56c9-dd98-3082b7b68abe@polymtl.ca> (Simon Marchi's message of "Thu, 2 Apr 2020 10:55:06 -0400") Message-ID: <878sjdvhi4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jK56C-001NMG-90 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (murgatroyd) [174.16.110.145]:40470 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 19:01:59 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> + return bfd_get_section_contents (abfd, section, contents->data (), offset, count); This line looks too long. Simon> +/* Wrapper around bfd_get_section_contents, returning the requested section Simon> + contents in *CONTENTS. Return true on success, false otherwise. Simon> + Simon> + If COUNT is not specified, read from OFFSET until the end of the Simon> + section. */ Simon> + Simon> +bool Simon> +gdb_bfd_get_section_contents (bfd *abfd, asection *section, Normally in .h files we don't put a newline after the type. Simon> + gdb::byte_vector idata_contents; Simon> + if (!gdb_bfd_get_section_contents(abfd, idata_section, &idata_contents)) Space before paren. Otherwise this looks good. Thank you for doing this. Tom