From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.186.5]) by sourceware.org (Postfix) with ESMTPS id 00461387700D for ; Thu, 12 Mar 2020 18:20:04 +0000 (GMT) Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 1F232400C8F71 for ; Thu, 12 Mar 2020 12:35:39 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CSR5jbE838vkBCSR6jTY6p; Thu, 12 Mar 2020 13:20:00 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9lKkjcUqRalK/M+mvcidBH7c/kRBMsvRoGCbcbn+4qM=; b=Rbc+fGguonLgBe8ikKlKEDe2QZ vDMD36zAls2IgPUnAdbtLy/t9I/gNG2iuFSmpCmx7facWgeYT7nZFltlNnikj4RBz1ERMiiqH2diw 41Qu8S1bPk9fi8OLy4TKlNuYx; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:60552 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jCSR5-001iwY-Lf; Thu, 12 Mar 2020 12:19:59 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: make gdb.arch/amd64-disp-step-avx.exp actually test displaced stepping References: <20200305222108.27194-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Thu, 12 Mar 2020 12:19:58 -0600 In-Reply-To: <20200305222108.27194-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 5 Mar 2020 17:21:08 -0500") Message-ID: <878sk5jv01.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jCSR5-001iwY-Lf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:60552 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 18:20:05 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> The test gdb.arch/amd64-disp-step-avx.exp is meant to test that doing a Simon> displaced step of an AVX instruction works correctly. However, I found Simon> (by pure coincidence) that the test instructions are not actually Simon> displaced stepped. Rather, they are inline-stepped, so the test is not Simon> actually testing what it's meat to test. Typo "meat" -> "meant". Nice catch here. I think the patch looks good. Tom