From: Tom Tromey <tom@tromey.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: bfd_get_filename
Date: Mon, 09 Sep 2019 18:17:00 -0000 [thread overview]
Message-ID: <878sqx9vx2.fsf@tromey.com> (raw)
In-Reply-To: <20190906132914.GJ30165@bubble.grove.modra.org> (Alan Modra's message of "Fri, 6 Sep 2019 22:59:14 +0930")
>>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:
Alan> This macro says:
Alan> /* Cast from const char * to char * so that caller can assign to
Alan> a char * without a warning. */
Alan> I reckon that isn't such a good idea since it can result in char*
Alan> variables where const char* is appropriate. Not very many places
Alan> need the char* cast. Applying to gdb as obvious.
Thanks for doing this. I came up with a couple of follow-up patches to
remove some of the casts. I'll send those soon.
Tom
prev parent reply other threads:[~2019-09-09 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:29 bfd_get_filename Alan Modra
2019-09-09 18:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sqx9vx2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).