From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38295 invoked by alias); 9 Sep 2019 18:17:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38277 invoked by uid 89); 9 Sep 2019 18:17:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:bfd_get X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.45.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 18:17:15 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id C61BF400D3C35 for ; Mon, 9 Sep 2019 12:11:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7ODyiF7Dl2PzO7ODyi9X9f; Mon, 09 Sep 2019 13:17:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yLlltDi60aoL3IWInsN4lpB/dA23u79UTVPWx/7xsD8=; b=Q2WnvkwFSRIVw4yhcqGEF990R0 IhPe9eKg1oBZ5tCiFLletPjnrolvzTVRCome+oU89De3YobJ5zvxqhnW4hFHSuqVesCTS0elaCAI6 AdqbcOeOh6cim2+9ZGaCoD0Kg; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:52682 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7ODy-0012oH-3X; Mon, 09 Sep 2019 13:17:14 -0500 From: Tom Tromey To: Alan Modra Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: bfd_get_filename References: <20190906132914.GJ30165@bubble.grove.modra.org> Date: Mon, 09 Sep 2019 18:17:00 -0000 In-Reply-To: <20190906132914.GJ30165@bubble.grove.modra.org> (Alan Modra's message of "Fri, 6 Sep 2019 22:59:14 +0930") Message-ID: <878sqx9vx2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00141.txt.bz2 >>>>> "Alan" == Alan Modra writes: Alan> This macro says: Alan> /* Cast from const char * to char * so that caller can assign to Alan> a char * without a warning. */ Alan> I reckon that isn't such a good idea since it can result in char* Alan> variables where const char* is appropriate. Not very many places Alan> need the char* cast. Applying to gdb as obvious. Thanks for doing this. I came up with a couple of follow-up patches to remove some of the casts. I'll send those soon. Tom