From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53782 invoked by alias); 13 Sep 2018 15:08:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53768 invoked by uid 89); 13 Sep 2018 15:08:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:850 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Sep 2018 15:08:49 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id CBCD8D89E for ; Thu, 13 Sep 2018 10:07:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0TDcgBiAlBcCX0TDcgbu7X; Thu, 13 Sep 2018 10:07:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yBHEWgNDd0Mi4T+k9xBuExt+b0NefxDpewtW5Pbeeko=; b=HHxKt8rPt0fGoOajUSKZy80loy LgkSGLkMm/3v8zXSj6Ft6WouK32QC2A4GJ2kAz0yYB7Y6tTdrF+u7RO/tgtHom2nTUhFgFnm2U5Pk VyZycvErYN3O1WK/A3pKLvCJ9; Received: from 97-122-189-157.hlrn.qwest.net ([97.122.189.157]:35470 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g0TDc-0025aT-GX; Thu, 13 Sep 2018 10:07:44 -0500 From: Tom Tromey To: John Baldwin Cc: Simon Marchi , GDB Patches Subject: Re: [PATCH 3/5] Add support for 'info proc files' on FreeBSD core dumps. References: <20180908003659.37482-1-jhb@FreeBSD.org> <20180908003659.37482-4-jhb@FreeBSD.org> <26938c44-7bab-3951-ff2f-d0567d3aee39@ericsson.com> Date: Thu, 13 Sep 2018 15:08:00 -0000 In-Reply-To: (John Baldwin's message of "Mon, 10 Sep 2018 12:37:15 -0700") Message-ID: <878t45qvuo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00425.txt.bz2 >>>>> "John" == John Baldwin writes: John> That comment is in the structure 'struct kinfo_ofile' which is for John> an older format of this structure used in FreeBSD 7.0 kernels. 7.1 John> and later kernels use the 'struct kinfo_file' structure which has a John> fixed layout (and includes an explicit kf_pad0 padding field). FreeBSD John> didn't add the NT_PROCSTAT_FILES note to process core dumps until FreeBSD John> 10.0 (also merged to 9.2), so process cores have only ever included the John> newer format with a fixed layout. John> If it is helpful I could add a comment. I think I redid the same John> archaeology when adding the initial 'info proc' core dump bits for John> FreeBSD. :) I think a comment sounds helpful for future developers. Tom