public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simark@simark.ca>,
	 Andrew Burgess <andrew.burgess@embecosm.com>,
	 gdb-patches@sourceware.org
Subject: Re: [RFA] Remove VEC from breakpoint
Date: Wed, 04 Jul 2018 17:29:00 -0000	[thread overview]
Message-ID: <878t6qq58b.fsf@tromey.com> (raw)
In-Reply-To: <87h8lfpnkc.fsf@tromey.com> (Tom Tromey's message of "Tue, 03 Jul	2018 23:38:59 -0600")

Tom> The main risk of it is that I can't compile all the nat-* files.

... but one of the buildbot builders failed like this:

../../binutils-gdb/gdb/bsd-uthread.c: In member function virtual void bsd_uthread_target::fetch_registers(regcache*, int):
../../binutils-gdb/gdb/bsd-uthread.c:326:18: error: unused variable save_inferior_ptid [-Werror=unused-variable]
   scoped_restore save_inferior_ptid = make_scoped_restore (&inferior_ptid);
                  ^


However this object is used -- it is used for the side effects of its
destructor.

Presumably this is a gcc bug, fixed since then.  But I don't know if
there's a reasonable way to work around it.  So maybe -Wunused-variable
can't be used yet.

I will see about submitting the bug fixes as separate fixes.  Though
it's a shame not to then get the systematic improvement as well.

Tom

  reply	other threads:[~2018-07-04 17:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 19:23 Tom Tromey
2018-07-03 14:33 ` Andrew Burgess
2018-07-04  4:40   ` Simon Marchi
2018-07-04  5:39     ` Tom Tromey
2018-07-04 17:29       ` Tom Tromey [this message]
2018-07-09  4:09         ` Tom Tromey
2018-07-09  4:21           ` Tom Tromey
2018-07-11  2:25             ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878t6qq58b.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).