From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove cleanups from ser-mingw.c
Date: Mon, 18 Jun 2018 14:17:00 -0000 [thread overview]
Message-ID: <878t7ckwly.fsf@tromey.com> (raw)
In-Reply-To: <b7ce9d43-9eee-98eb-e740-1ca783b97848@simark.ca> (Simon Marchi's message of "Sun, 17 Jun 2018 23:16:30 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> - scb->state = (void *) ps;
>> + scb->state = (void *) ps.release ();
Simon> - I think we could remove the cast, unless you think it helps readability.
Simon> - I think we could remove the goto fail mechanism now.
Agreed on both counts, I made this change.
>> argv.release ();
Simon> Side note: doesn't this argv.release() look fishy to you? Who ends up owning it?
It is fishy. I looked at the history and it seems that when I added
gdb_argv here, I kept things working the same; I suppose without looking
too hard. I looked and PEX does not seem to take ownership of the
arguments, so removing this line seems correct to me, and I've done that
in the version that I will check in.
Tom
prev parent reply other threads:[~2018-06-18 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 21:21 Tom Tromey
2018-06-18 3:16 ` Simon Marchi
2018-06-18 14:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t7ckwly.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).